370183 - File > Open saved message does nothing anymore

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

File > Open saved message... doesn't do anything anymore. No errors in the console either. Regressed on branch 2007-02-08 > 2007-02-09. 

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-08&maxdate=2007-02-09&cvsroot=%2Fcvsroot

Fallout from bug 257885 perhaps?

Comment 1

[David :Bienvenu]

wfm with my debug 2.0 build, which is up to date in mailnews and mail (but might be out of date in other directories)

Comment 2

[Scott MacGregor]

This doesn't work for me in yesterday's nightly branch build (02/11).

The menu is enabled but nothing happens. Given David's data point maybe the regression is something outside of mail/mailnews.

Comment 3

[Magnus Melin [:mkmelin]]

Confirmed this is a regression from bug 257885. Patch coming up.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

This fixes this bug for me. It is also what seamonkey does.

The changes that regressed this also makes menu_Edit undo/redo have both command and oncommand. Don't know if that is correct, but undo/redo seems to work as is.

Comment 5

[Scott MacGregor]

Comment on attachment 255122 [details] [diff] [review]
proposed fix

Magnus, do you mind attaching a patch that removes:

oncommand="Undo()"

and oncommand="Redo()"

from here as well:

http://lxr.mozilla.org/mozilla/source/mail/base/content/mailWindowOverlay.xul#1244

Thanks!

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Removed the undo/redo oncommand="..." as well.

Comment 7

[Scott MacGregor]

Comment on attachment 255476 [details] [diff] [review]
proposed fix, v2

thanks!

Comment 8

[Nickolay_Ponomarev]

mozilla/mail/base/content/mailWindowOverlay.xul   1.198

Comment 9

[Mike Cowperthwaite]

Why checked in for trunk only?  This already has TB2 approval.

Comment 10

[Nickolay_Ponomarev]

Because checking into 1.8 means watching several more trees and there are several other bugs, waiting for 1.8 checkin. I'd rather check them in together to minimize the time spent on the hook.

Comment 12

[Scott MacGregor]

I landed this on the branch.

Comment 13

[Mike Cowperthwaite]

V with TB 2b2-0221, Win2K.  Thanks for the fix Magnus.  I really missed the feature while it was gone.

Comment 14

[Marcia Knous [:marcia]]

verified on the 1.8 branch using the Tbird candidate build, version 2.0.0.0 (20070326). I verified using Win Vista. Adding the branch verified keyword.