37025 - nsPluginsDirUNIX.cpp does not build due to dlopen() flags.

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[jim_nance]

nsPluginsDirUNIX.cpp does not build under Tru64 Unix because the
RTLD_GLOBAL flag that it passes do dlopen() is not defined on
that platform.  We really should be using PL_LoadLibrary() instead
of dlopen() if that is possible.

I have a temp fix for the alpha that defines RTLD_GLOBAL as 0 if
its not defined.  I am going to check that in, but we really should
fix this properly.  I did not want to remove the dlopen() calls
myself since there may be a reason they need to be there and I
do not know how to test it.

Comment 1

[rusty.lynch]

I added explicit dlopens for libXt.so and libXext.so since the main Mozilla
source doesn't normally link to these librarys, and the dlopen on a legacy
plug-in will fail if these symbols are not present.

I found that just linking to the librarys didn't do the trick if none of the
Mozilla code every attempts to use any of the Xt calls, but explicitly 
dlopen'ing the library (and specifying that the library symbols should be made
global) work fine.

Calling dlopen instead of the NSPR wrapped dlopen was just an oversite.

Comment 2

[rusty.lynch]

Attachment: patch to move to NSPR safe dlopen calls

Comment 3

[rusty.lynch]

The above patch uses the NSPR functions to open a shared library and globaly
share it's symbols.  I'm sure it's safe, but I would like someone with a Tru64
Unix system to try it out.  

Comment 4

[jim_nance]

I tried it on a Tru64 system, and it does not compile.  Its looks like a const
problem:

nsPluginsDirUNIX.cpp
cxx: Error: /scratch/jlnance/mozilla/modules/plugin/nglsrc/nsPluginsDirUNIX.cpp,
line 153:
          argument of type "const char *" is incompatible with parameter of
          type "void *"
    PR_FREEIF(tempSpec.value.pathname);
----^
cxx: Error: /scratch/jlnance/mozilla/modules/plugin/nglsrc/nsPluginsDirUNIX.cpp,
line 158:
          argument of type "const char *" is incompatible with parameter of
          type "void *"
    PR_FREEIF(tempSpec.value.pathname);
----^
cxx: Info: 2 errors detected in the compilation of "/scratch/jlnance/mozilla/mod

Comment 5

[Christopher Blizzard (:blizzard)]

Jim, can you fix up a patch that does work?  I think that you have access to at
least digital unix and linux systems to test on.

Comment 6

[jim_nance]

Sure, I will be glad to put something together based on rusty's patch

Comment 7

[jim_nance]

Attachment: The patch!

Comment 8

[jim_nance]

Bet yall thought I would never get this done :-)  Here it is.  Its basically
rusty's patch, but I realized that we dont really need to allocate memory
for the strings, which is what was leading to the compile problem in in
the first place.  Can someone review this for me?

Comment 9

[rusty.lynch]

the patch works for me.  What do you think, Chris? Can I check it in?

Comment 10

[Christopher Blizzard (:blizzard)]

Yep, looks good to me.

Comment 11

[jim_nance]

I will let rusty check this in then unless he wants me to do it.

Comment 12

[jim_nance]

I went ahead and checked it in.

Comment 13

[Brian Ryner (not reading)]

*** Bug 41112 has been marked as a duplicate of this bug. ***

Comment 14

[shrirang khanzode]

verif that the fix is in.