Open
Bug 370340
Opened 19 years ago
Updated 3 years ago
tests in nsprpub need "make check" support
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: ray, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
3.16 KB,
patch
|
Details | Diff | Splinter Review |
There are 150+ tests in the nsprpub directories. But they must be manually built and run. There is a "runtests.sh" script, but the way to do this is with a "check" target in make.
This is the way the buildbot-based test systems will be interacting with these tests.
The make target should be set up so that any error in the tests causes the make to return a non-zero value.
I have not this before. I tried this on my intel Mac. I cannot tell about Win and Linux.
A "make check" in the top-level directoy now builds and runs the tests.
Attachment #259566 -
Flags: review?(wtchang)
Sorry for my ungrammaticalness. It was late at night when I put this patch in.
What I was trying to say is that I made it so that a 'make check' in the nsprpub directory will build and run the tests. I assume that this is what is required for the tests to be invoked by the test builds.
I have included a check in the runtests.ksh file to ensure that this does not get run on the Mac, since it does not seem to work. Is it necessary for both of these nearly identical scripts to exist?
Attachment #259566 -
Attachment is obsolete: true
Attachment #259600 -
Flags: review?(wtchang)
Attachment #259566 -
Flags: review?(wtchang)
|
||
Comment 3•3 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: wtc → nobody
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•