370422 - [FIX]Select drop down button doesn't update its position in this case when document widens

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, the iframe gets wider after 0.5 seconds.
The select drop down should become wider then, also, but in current trunk builds, the select drop down stays at the same place.

This regressed between 2007-01-26 and 2007-01-28:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-01-26+05&maxdate=2007-01-28+09&cvsroot=%2Fcvsroot
My guess is a regression from bug 163504 or bug 9458.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I see this regress between 2007-01-27-02 and 2007-01-28-01:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-01-27+02&maxdate=2007-01-28+01&cvsroot=%2Fcvsroot

Possible cuprits are some of the things David landed, and bug 365477.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well, it's not bug 365477 (tested by local backout).

Comment 3

[Boris Zbarsky [:bzbarsky]]

So this is a regression from the patch in bug 163504...  The issue is that the combobox display frame has a width that depends on the available width, but it's not flagged as such in any way.

We can fix this bug by setting that frame to "display: inline-block", though that's just there to appease the check bug 163504 added, since we still munge the width.  Is there a way we could nix the width-munging altogether, short of using table-cell display or something?  Basically, we want to take up all the space except for the width of the dropdown marker.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Hack that sorta fixes this

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should just add the frame type to the list in IsPercentageAware, no?  (nsLineLayout.cpp, around line 750)  The hack would only fix it if it were !important, and I don't think that's necessary.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This frame doesn't have a special frame type (though we could add one, I guess), but content can't style it in any case.  So the non-!important thing does work.

I guess adding a frame type is the easiest thing to do here, if we can't get rid of that frame class altogether.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, ok, hadn't realized it was one of the inner frames.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: With a frame type

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 10

[Jeff Walden [:Waldo]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/reftests/bugs&command=DIFF_FRAMESET&file=reftest.list&rev1=1.2&rev2=1.3&root=/cvsroot