Port bug 369103 to embed-replacements copy of config.css

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

({fixed1.8.1.3})

Details

(URL)

Attachments

(1 attachment)

Created attachment 255193 [details] [diff] [review]
ports the fix

Bug 369103 made some changes to config.css; we should probably port them to our copy (on branch and trunk) to make future changes there easier to follow/merge.  Doing this now will also save us some time during crunch time when we audit the embed-replacements files before release to make sure we're all caught up.

I've applied the changes and rebuilt and can notice no adverse affects (i.e., it's not to a part that we need/override), but asking for some CSS review to be sure I haven't missed anything :)

I also added a comment to the file that points to the original file's location in the tree, as we're doing with other files in embed-replacements as we touch them.
Attachment #255193 - Flags: review?(phiw)

Comment 1

12 years ago
Comment on attachment 255193 [details] [diff] [review]
ports the fix

Looks OK.
Attachment #255193 - Flags: review?(phiw) → review+
Comment on attachment 255193 [details] [diff] [review]
ports the fix

There's a stray space on the first inserted (blank) line, which I didn't catch before and hope can be wacked on checkin....
Attachment #255193 - Flags: superreview?(stuart.morgan)

Comment 3

12 years ago
Comment on attachment 255193 [details] [diff] [review]
ports the fix

sr=smorgan
Attachment #255193 - Flags: superreview?(stuart.morgan) → superreview+
Whiteboard: [needs checkin]

Comment 4

12 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1.3
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.