370494 - Allow viewing addons ordered by their rating, popularity etc.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, enhancement)

Description

[Alex Sirota (iosart)]

Currently, remora shows add-ons sorted by name, and there isn't an options for users to view add-ons by most-popular, top rated, newest and so on.

There is a huge number of addons overall and in each category, so viewing them ordered alphabetically isn't very useful. Think of YouTube or Flickr with videos/photos ordered alphabetically.

Proposal:
1. Change default sorting to 'most popular' 
2. Allow users to change the sorting to 'top rated', 'most recent', 'by name'
3. Allow users to see clearly what the current sorting is

Comment 1

[Alex Sirota (iosart)]

Attachment: Suggested implementation for sort changing and display UI element

Comment 2

[Alex Sirota (iosart)]

Attachment: Sort implementation in Addons controller

This patch allows sorting through URLs such as:

http://addons.mozilla.org/en-US/firefox/browse/type:1/cat:all
http://addons.mozilla.org/en-US/firefox/browse/type:1/cat:all/sort:popular
http://addons.mozilla.org/en-US/firefox/browse/type:1/cat:all/sort:newest
http://addons.mozilla.org/en-US/firefox/browse/type:1/cat:all/sort:toprated
http://addons.mozilla.org/en-US/firefox/browse/type:1/cat:all/sort:name

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 255209 [details] [diff] [review]
Sort implementation in Addons controller

Please add tests for this before requesting review of the patch.

Comment 4

[Alex Sirota (iosart)]

(In reply to comment #3)
> Please add tests for this before requesting review of the patch.
Will do, wasn't sure what the procedure was... 

Comment 5

[Alex Sirota (iosart)]

Attachment: Unit test for sorting options

Attaching a unit-test for the new sorting code. 
Currently, the test uses the 3 addons in the sample DB.
We can add more sample addons (about 20?) and update the $all_expected_results array in the test accordingly.

Comment 6

[Fred Wenzel [:wenzel]]

Alright, I added the addon sort order and RSS feeds in SVN r2451. It'll be on stage shortly, and on preview when it is published the next time.

Alex, thanks for your help. While I did not just apply your patches (we are not juggling with as many big arrays anymore, instead we have SQL do the work as it is supposed to be ;)), I for example almost literally used your unit test. Well done.