Miscellaneous folder picker widget fixes

RESOLVED FIXED

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({fixed-seamonkey1.1.2, fixed1.8.1.3})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
* Use enableKeyboardNavigator to avoid having to add extra event listeners (although this requires us to call event.preventDefault)
* Fix click events only to work with the left button and not fire if the mouse was over blank space at the end of the list
(Assignee)

Comment 1

11 years ago
Created attachment 255227 [details] [diff] [review]
Possible patch

This version allows the tab key to fire when the popup is open.
Assignee: mscott → neil
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 255228 [details] [diff] [review]
Proposed patch

This version doesn't allow the tab key to fire when the popup is open.
Attachment #255228 - Flags: review?(mscott)

Comment 3

11 years ago
Comment on attachment 255228 [details] [diff] [review]
Proposed patch

Neil, would these changes apply to the branch as well?
Attachment #255228 - Flags: review?(mscott) → review+
(Assignee)

Comment 4

11 years ago
Created attachment 255329 [details] [diff] [review]
Missed a hunk

Sorry, I accidentally left this bit out, which is needed to complete the fix to the "click on blank area at the bottom of completely scrolled picker" bug.

(In reply to comment #3)
>(From update of attachment 255228 [details] [diff] [review])
>Neil, would these changes apply to the branch as well?
Yes, these patches could go on the branch.
Attachment #255227 - Attachment is obsolete: true
Attachment #255329 - Flags: review?(mscott)

Comment 5

11 years ago
Comment on attachment 255329 [details] [diff] [review]
Missed a hunk

ok. I'm going to approve them for the branch then. Feel free to let it bake on the trunk for a couple days if you want. I'll let you make that call.
Attachment #255329 - Flags: review?(mscott)
Attachment #255329 - Flags: review+
Attachment #255329 - Flags: approval-thunderbird2+

Updated

11 years ago
Attachment #255228 - Flags: approval-thunderbird2+
(Assignee)

Comment 6

11 years ago
Fixes checked in to the trunk, for now.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

11 years ago
Fix checked in to the branch.
Keywords: fixed-seamonkey1.1.2, fixed1.8.1.3

Comment 8

11 years ago
I have a user complaining that the folder picker widget doesn't handle deeply nested folders - it doesn't grow its width to fit deeply nested or hierarchies with long folder names, and doesn't have a horizontal scroll bar...in particular, when you pick a folder to search on in the advanced search UI, though I think it's also true for the toolbar folder picker widget. Is there anything that can be done about this?
(Assignee)

Comment 9

11 years ago
(In reply to comment #8)
>I have a user complaining that the folder picker widget doesn't handle deeply
>nested folders - it doesn't grow its width to fit deeply nested or hierarchies
>with long folder names, and doesn't have a horizontal scroll bar...in
>particular, when you pick a folder to search on in the advanced search UI,
>though I think it's also true for the toolbar folder picker widget. Is there
>anything that can be done about this?
We can't make it size to fit. On trunk we could in theory give it a horizontal scroll bar, but we'd still have to pick an arbitrary width.

Comment 10

11 years ago
Would that mean the scroll bar would appear even if there was no string wider than the actual displayed width? Or just that we'd have to pick a max width that could be scrolled? 
(Assignee)

Comment 11

11 years ago
(In reply to comment #10)
>Would that mean the scroll bar would appear even if there was no string wider
>than the actual displayed width?
Correct.
You need to log in before you can comment on or make changes to this bug.