370516 - Miscellaneous folder picker widget fixes

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[e-mail]]

* Use enableKeyboardNavigator to avoid having to add extra event listeners (although this requires us to call event.preventDefault)
* Fix click events only to work with the left button and not fire if the mouse was over blank space at the end of the list

Comment 1

[[e-mail]]

Attachment: Possible patch

This version allows the tab key to fire when the popup is open.

Comment 2

[[e-mail]]

Attachment: Proposed patch

This version doesn't allow the tab key to fire when the popup is open.

Comment 3

[Scott MacGregor]

Comment on attachment 255228 [details] [diff] [review]
Proposed patch

Neil, would these changes apply to the branch as well?

Comment 4

[[e-mail]]

Attachment: Missed a hunk

Sorry, I accidentally left this bit out, which is needed to complete the fix to the "click on blank area at the bottom of completely scrolled picker" bug.

(In reply to comment #3)
>(From update of attachment 255228 [details] [diff] [review])
>Neil, would these changes apply to the branch as well?
Yes, these patches could go on the branch.

Comment 5

[Scott MacGregor]

Comment on attachment 255329 [details] [diff] [review]
Missed a hunk

ok. I'm going to approve them for the branch then. Feel free to let it bake on the trunk for a couple days if you want. I'll let you make that call.

Comment 6

[[e-mail]]

Fixes checked in to the trunk, for now.

Comment 7

[[e-mail]]

Fix checked in to the branch.

Comment 8

[David :Bienvenu]

I have a user complaining that the folder picker widget doesn't handle deeply nested folders - it doesn't grow its width to fit deeply nested or hierarchies with long folder names, and doesn't have a horizontal scroll bar...in particular, when you pick a folder to search on in the advanced search UI, though I think it's also true for the toolbar folder picker widget. Is there anything that can be done about this?

Comment 9

[[e-mail]]

(In reply to comment #8)
>I have a user complaining that the folder picker widget doesn't handle deeply
>nested folders - it doesn't grow its width to fit deeply nested or hierarchies
>with long folder names, and doesn't have a horizontal scroll bar...in
>particular, when you pick a folder to search on in the advanced search UI,
>though I think it's also true for the toolbar folder picker widget. Is there
>anything that can be done about this?
We can't make it size to fit. On trunk we could in theory give it a horizontal scroll bar, but we'd still have to pick an arbitrary width.

Comment 10

[David :Bienvenu]

Would that mean the scroll bar would appear even if there was no string wider than the actual displayed width? Or just that we'd have to pick a max width that could be scrolled? 

Comment 11

[[e-mail]]

(In reply to comment #10)
>Would that mean the scroll bar would appear even if there was no string wider
>than the actual displayed width?
Correct.