370607 - Different search fields produce two different search URLs

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wladimir Palant]

If you type the word "test" into the search field in the header of any page you will be directed to http://preview.addons.mozilla.org/en-US/firefox/search?q=test&status=4. If you use the search field on http://preview.addons.mozilla.org/en-US/firefox/search however you will get http://preview.addons.mozilla.org/en-US/firefox/search/?q=test&status=4 (note the slash after "search"). The way URLs are built in Remora I think the second version is wrong. So the following line in /app/views/search/index.thtml:

<form action="<?=$html->url('/search/')?>" method="get" class="amo-form corner-box">

should be replaced by:

<form action="<?=$html->url('/search')?>" method="get" class="amo-form corner-box">

Comment 1

[Wladimir Palant]

Same issue with the "Recommended Add-ons" link: on http://preview.addons.mozilla.org/en-US/firefox "We've got a list of some of our favorite add-ons" links to http://preview.addons.mozilla.org/en-US/firefox/recommended/ whereas the sidebar has the correct link (without the trailing slash). That's /app/views/addons/home.thtml that needs fixing in this case.

Comment 2

[Fred Wenzel [:wenzel]]

Thanks for pointing this out. I fixed both of these in trunk (SVN r2264) -- while it doesn't make a difference to the application if you have a trailing slash or not, it is certainly better to be consistent here.