370694 - Thunderbird's vendorShortName should be Mozilla not Mozilla Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

This should be a good cleanup bug for someone to help out on.

We used to use vendorShortName in our old mapi implementation and it needed the value to be Mozilla Thunderbird. But this isn't true anymore, we no longer use that code in Thunderbird.

To do:
1) Make vendorShortName be Mozilla not Thunderbird in the various brand dtd and property files for Thunderbird.
2) Remove hacks folks have added over time to account for the fact that the vendor short name wasn't really a short name. Most notably:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/nsPostUpdateWin.js#625
http://lxr.mozilla.org/mozilla/source/mail/app/profile/all-thunderbird.js#73

Comment 1

[Scott MacGregor]

Attachment: fix vendorShortName in Thunderbird

This is for the trunk only since it changes the vendorShortName strings.

Rob, do you mind reviewing the toolkit specific change to nsPostUpdateWin.js to stop using the app.update.vendorName.override pref? This was a hack added to nsPostUpdateWin to work around the fact that the vendorShortName for Thunderbird wasn't set correctly.

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> Created an attachment (id=255419) [details]
> fix vendorShortName in Thunderbird
> 
> This is for the trunk only since it changes the vendorShortName strings.
> 
> Rob, do you mind reviewing the toolkit specific change to nsPostUpdateWin.js to
> stop using the app.update.vendorName.override pref? This was a hack added to
> nsPostUpdateWin to work around the fact that the vendorShortName for
> Thunderbird wasn't set correctly. 
Not at all if you also fix the EM Thunderbird vendorShortName workaround! :)
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#1347

Comment 3

[Scott MacGregor]

oy...that one is tougher I'm afraid. We don't pass "Mozilla" as the vendor name in nsXREAppData because it alters the location of thunderbird profiles on disk. 

We'd like to eventually set it to "Mozilla". That would fix Bug 247973 but we don't want to migrate existing profiles into the new location. We need to figure out https://bugzilla.mozilla.org/show_bug.cgi?id=247973#c19 first.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 255419 [details] [diff] [review]
fix vendorShortName in Thunderbird

darn... can't lose hope though! ;)

r=me on the toolkit changes and thanks!