370717 - ssl2_StartGatherBytes() is dead or the comment is out of date

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Tammy]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9
Build Identifier: firefox 2.0.0.1

* Called from SocksStartGather in sslsocks.c
 * Caller must hold RecvBufLock. 
 */     
int     
ssl2_StartGatherBytes(sslSocket *ss, sslGather *gs, unsigned int count)
{           }

But this function is not called  in sslsocks.c. Actually sslsocks.c does not exist. I do find sslsock.c, but it is NOT called in it.


Reproducible: Always

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Yup.  ssl2_StartGatherBytes is dead code.  
sslsocks.c was removed from NSS way way back in NSS 2.x time.
Thanks for catching this.

Comment 2

[:Cykesiopka]

Attachment: bug370717_v1.patch

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 8386583 [details] [diff] [review]
bug370717_v1.patch

r=kaie

Comment 4

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/5d5cf4865913