Closed Bug 370717 Opened 16 years ago Closed 9 years ago

ssl2_StartGatherBytes() is dead or the comment is out of date

Categories

(NSS :: Libraries, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
3.16.1

People

(Reporter: lintan2, Assigned: Cykesiopka)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.9) Gecko/20061206 Firefox/1.5.0.9
Build Identifier: firefox 2.0.0.1

* Called from SocksStartGather in sslsocks.c
 * Caller must hold RecvBufLock. 
 */     
int     
ssl2_StartGatherBytes(sslSocket *ss, sslGather *gs, unsigned int count)
{           }

But this function is not called  in sslsocks.c. Actually sslsocks.c does not exist. I do find sslsock.c, but it is NOT called in it.


Reproducible: Always
Yup.  ssl2_StartGatherBytes is dead code.  
sslsocks.c was removed from NSS way way back in NSS 2.x time.
Thanks for catching this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Version: unspecified → 3.0
Attachment #8386583 - Flags: review?(kaie)
Comment on attachment 8386583 [details] [diff] [review]
bug370717_v1.patch

r=kaie
Attachment #8386583 - Flags: review?(kaie) → review+
https://hg.mozilla.org/projects/nss/rev/5d5cf4865913
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.16.1
Assignee: nobody → cykesiopka.bmo
You need to log in before you can comment on or make changes to this bug.