370773 - When the spelling check dictionary is installed in a Japanese version, the selection dictionary is displayed with Preferences by mistake

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Hiro]

When the spelling check dictionary is installed in a Japanese version, The installed dictionary does the display chosen though it has not chosen yet. 

Therefore, when the spelling check works, it misunderstands it. 
(Actually, the spelling check doesn't work until the dictionary is chosen. )

In the list of the selection dictionary of the spelling check dialog, this problem is not. 
(The list is an empty column until the dictionary is chosen. )

The dictionary of the check on the spelling of Preferences setting should do the same display 
as the spelling check dialog. 

Reproducible: Always

Steps to Reproduce:
1. Install 1.8branch nightly Japanese package
2. Setup mail account
3. Install  spell check dictionary(english)
4. Open new message and Some characters are input to the text. 
      -- The spelling check doesn't work. 
5. Open Preferences --> Composition --> Spelling
     -- The dictionary has been selected.

Expected Results: 
The list is a blank just like the spelling check dialog until the dictionary is chosen. 

1.8branch ja-JP nightly build

Mac OS X 10.3.9
 (20070130)
Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.2pre) Gecko/20070216 Thunderbird/2.0pre

Comment 1

[Hiro]

Attachment: quick patch

To display it just like the spelling check dialog, it changes. 
http://lxr.mozilla.org/mozilla/source/editor/ui/dialogs/content/EdSpellCheck.js#249

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

the patch looks good for me

Hiro-san:
You should request r+sr.

Comment 3

[Hiro]

Comment on attachment 255502 [details] [diff] [review]
quick patch

thanks pre check, nakano-san.

Comment 4

[Scott MacGregor]

I'm not sure I understand the bug report. Does this fix the following scenario:

* Use a locale that does not ship with a dictionary. 
* Install a dictionary as an extension.
* Start typing in a compose window and note that the inline spell checker is not identifying any mispelled words. 

The user has to manually choose the installed dictionary before we start using it.

Did I get that right?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

You are right. For Japanese language, our code doesn't check the spell check. And the like spell checking is done by third party's IMEs  (e.g., ATOK) if it is used. Because our language doesn't have miss spelled words. There are only the wrong words they are same pronunciation in the context. Therefore, ja-JP version doesn't set the any dictionaries in default settings. 

If the users needs to use western languages, they need to download/install the dictionaries to Tb, and set it.

Comment 6

[Scott MacGregor]

Comment on attachment 255502 [details] [diff] [review]
quick patch

ah thank you for the explanation masayuki. In that case a=mscott

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.