Closed Bug 370785 Opened 17 years ago Closed 17 years ago

Suppress Go button for dom.disable_window_open_feature.location case

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Assigned: ventnor.bugzilla)

Details

Attachments

(1 file)

If you set dom.disable_window_open_feature.location to true, popup windows get a read-only location bar whether or not they want it, but since the Go button got integrated into the location bar, they now also get a "working" Go button (where the only work it will do is reload the static URL).
Attached patch PatchSplinter Review
Hide the go button when the location bar is set as readonly.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #255548 - Flags: review?(mano)
Comment on attachment 255548 [details] [diff] [review]
Patch

r=mano.
Attachment #255548 - Flags: review?(mano) → review+
Thanks Mano, though can I ask you for another favour? I don't have CVS checkin rights so.... :)
You can update the status whiteboard with "[checkin needed]" and the right thing will happen fairly quickly.  :-)
Whiteboard: [checkin needed]
browser/base/content/browser.js 1.765

Thanks, Michael.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
No longer blocks: 337344
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: