generic container icon is used for live-bookmarks containers which were added incrementally

VERIFIED FIXED in Firefox 3 alpha5

Status

()

Firefox
Bookmarks & History
P3
normal
VERIFIED FIXED
11 years ago
4 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

Trunk
Firefox 3 alpha5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The generic container icon is used for live-bookmarks containers which were added incrementally.

STR:
  1. Open the organizer.
  2. Expand the toolbar folder in the left pane
  3. From the browser window you didn't close, Subscribe to your favorite feed using live bookmarks.

The item is correctly added to the organizer's left pane, but with the generic container icon. This happens because we set the icon only after calling createContainer (which invalidates the range); see _createFolder in nsLivemarkService.

At the very least, we should make sure to update the view when the favicon for a node is modified. We should also consider adding an optional icon argument to createContainer.
Created attachment 255859 [details] [diff] [review]
partial patch

This makes sure we call the observers for such nodes. For some reason though it looks like the BM observer (for the result loaded in the content pane) is no longer set at this point.
ignore the /* static */ bit.

Target Milestone: --- → Firefox 3 alpha6
Created attachment 266181 [details] [diff] [review]
patch
Assignee: nobody → mano
Attachment #255859 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #266181 - Flags: review?(dietrich)
Priority: -- → P3
Target Milestone: Firefox 3 alpha6 → Firefox 3 alpha5
Comment on attachment 266181 [details] [diff] [review]
patch

r=me, thanks
Attachment #266181 - Flags: review?(dietrich) → review+
Blocks: 376725
Flags: in-testsuite?
mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.97
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

11 years ago
verified with Windows trunk build from 20070620
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.