370966 - Fix error handling in nsPrintEngine

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Eli Friedman]

I'll post a patch sometime pretty soon.  One major issue: FirePrintCompletionEvent can destroy a subsequent print engine in the case where a print dialog get cancelled, e.g. data:text/html,<script>print();print();</script> crashes if you cancel the first print dialog.

Comment 1

[Eli Friedman]

Attachment: Patch

In the interest of making things easier to read, I merged Print() and PrintPreview().  This makes it clearer where they are the same and where they differ.

This patch makes the error handling much more consistent; also, it uses NS_ENSURE_*, so it should consistently warn when something unexpected happens.

Comment 2

[Eli Friedman]

Checked in.