371076 - query root node should be exposed in the tree view

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

In the tree view, the root result node should be exposed as the tree root node.

Right now direct children of the query root are the root node(s).

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: wip patch

So, this works for the organizer's left pane, but breaks everything else (history sidebar, bookmarks sidebar, organizer content pane). Really, the only place where we want the root visible is in that one view in the organizer.

Possibly could add a "promoteRoot" query option, which makes the root node visible in the tree. Or maybe a more generic "startLevel" option, which will make the tree visible starting at the specified level of depth.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

Adds a showRoot query option.

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: fix v2 - includes fix for 371077 (removes excludeQueries from bookmarks queries)

Comment 4

[Asaf Romano (gone)]

Comment on attachment 257930 [details] [diff] [review]
fix v2 - includes fix for 371077 (removes excludeQueries from bookmarks queries)

r=mano, thanks!

Comment 5

[Asaf Romano (gone)]

Update the UUID of nsINavHistoryQueryOptions please.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 257930 [details] [diff] [review]
fix v2 - includes fix for 371077 (removes excludeQueries from bookmarks queries)

Hrm, sorry. It took me a little while to figure this adds the root item as a static "free" item (it has no children, the query contents are in the same level).

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: fix v3 - proper parentage

Comment 8

[Asaf Romano (gone)]

Comment on attachment 258257 [details] [diff] [review]
fix v3 - proper parentage

r- for the viewIndex issue we discussed over IRC.

Comment 9

[Asaf Romano (gone)]

Attachment: patch

Comment 10

[Asaf Romano (gone)]

Comment on attachment 259620 [details] [diff] [review]
patch


>+      if (this._showRoot) {
>+        // List the root node
>+        this._visibleElements.push(this._result.root);
>+        this._result.root.viewIndex = 0;
>+      }
>+      else if (!rootNode.containerOpen) {
>+        // this triggers containerOpened which then builds the visible
>+        // selection
>+        rootNode.containerOpen = true;

visible /section/.

Comment 11

[Asaf Romano (gone)]

note to self #2:
  this._visibleElements.push(rootNode);
  rootNode.viewIndex = 0;

Comment 12

[Dietrich Ayala (:dietrich)]

Comment on attachment 259620 [details] [diff] [review]
patch

Index: browser/components/places/content/bookmarkProperties.xul
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/places/content/bookmarkProperties.xul,v
>retrieving revision 1.20
>diff -u -p -8 -r1.20 bookmarkProperties.xul
>--- browser/components/places/content/bookmarkProperties.xul	22 Mar 2007 23:13:57 -0000	1.20
>+++ browser/components/places/content/bookmarkProperties.xul	25 Mar 2007 21:28:15 -0000
>@@ -83,17 +83,18 @@
>                   <label value="&bookmark.property.parents;"/>
>                 </hbox>
>               </vbox>
>               <vbox>
>                 <tree id="folderTree"
>                       class="placesTree"
>                       flex="1"
>                       type="places"
>-                      place="place:&amp;folder=1&amp;group=3&amp;excludeItems=1&amp;excludeQueries=1&amp;excludeReadOnlyFolders=1"
>+                      showRoot="true"
>+                      place="place:&amp;folder=2&amp;group=3&amp;excludeReadOnlyFolders=1"

excludeItems should not have been removed, right?

r=me with this fixed

Comment 13

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/toolkit/components/places/public/nsINavHistoryService.idl 1.53
mozilla/toolkit/components/places/src/nsNavHistoryResult.h 1.31
mozilla/browser/components/places/content/bookmarkProperties.xul 1.22
mozilla/browser/components/places/content/bookmarksPanel.xul 1.4
mozilla/browser/components/places/content/places.xul 1.69
mozilla/browser/components/places/content/tree.xml 1.61
mozilla/browser/components/places/content/treeView.js 1.3

Comment 14

[Asaf Romano (gone)]

Attachment: that important attribute

Checking in browser/components/places/content/bookmarkProperties.xul;
/cvsroot/mozilla/browser/components/places/content/bookmarkProperties.xul,v  <--  bookmarkProperties.xul
new revision: 1.23; previous revision: 1.22
done

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv