37113 - Need better UI for "Save all attachments"

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Henrik Gemal]

After http://bugzilla.mozilla.org/show_bug.cgi?id=21742 got fixed this is a new 
bug report for the proper UI.
A lot of inspiration can be found in the attached image.

Comment 1

[Henrik Gemal]

Attachment: Save all attachment dialog in OE

Comment 2

[selmer (gone)]

Mail review recommends beta2 stopper.

Comment 3

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.

Comment 4

[selmer (gone)]

Targetting our beta2 candidates to M17.

Comment 5

[selmer (gone)]

Scott, Jeff, is this just a trivial UI hookup, or is it a lot of work that isn't 
done yet?

Comment 6

[Scott MacGregor]

marking future. You can save all attachments today. we just don't have a great
UI that matches the spec for it. This isn't an area we are focusing on for beta3
/ rtm.

Comment 7

[Henrik Gemal]

What is the spec? Something like Outlook Express's cool Save All dialog?

Comment 8

[fenella]

Assign it to [e-mail]

Comment 9

[fenella]

To Esther..

Comment 10

[Keyser Sose]

Isnt this been checked in? I have a UI on mine? Shouldnt this be marked FIXED?

Comment 11

[Keyser Sose]

Marking FIXED  feel free to reopen it if you feel otherwise.

Comment 12

[Henrik Gemal]

In the current UI setup you can only save all the attachments.
Outlook Express has a cool UI where you can choose which attachments you would 
like to save.
Perhaps this is just a RFE...

Comment 13

[Dimitrios]

Could someone explain me why this bug was considered as FIXED ? In 2001032904
Win32 build, there is no provision for it. Or maybe I misunderstood what the
purpose of this bug meant to be. Thanks.

Comment 14

[Henrik Gemal]

After the new mail&news diaplay has landed, the ability to save attachments has 
gone. There's another bug on that.

Comment 15

[esther]

Marking dup of latest Save All bug 73414: "Once I check in the new look for
message display, I'm going to be breaking the save all attachments feature. I
need to re-implement this with the new view."





*** This bug has been marked as a duplicate of 73414 ***

Comment 16

[esther]

verified as dup

Comment 17

[Henrik Gemal]

I'll reopen the bug since it's not a bug about implementing the "save all 
attachments" but a bug about improving the dialog.

Comment 18

[Koike Kazuhiko]

See bug 65866.

Which should be marked as duplicate?

Comment 19

[Henrik Gemal]

*** Bug 65866 has been marked as a duplicate of this bug. ***

Comment 20

[Koike Kazuhiko]

*** Bug 83965 has been marked as a duplicate of this bug. ***

Comment 21

[laurel]

*** Bug 102115 has been marked as a duplicate of this bug. ***

Comment 22

[Koike Kazuhiko]

*** Bug 62223 has been marked as a duplicate of this bug. ***

Comment 23

[Koike Kazuhiko]

Attachment: patch

Textfield in dialog shows pathname, and label is changed from
"File name" to "Directory name".

Comment 24

[Koike Kazuhiko]

Attachment: patch v2

I/F of nsIFile changed.

Comment 25

[Kevin Butler]

It should (but does not):

- default to the last "save as" directory
- let you type a path
- let you create a directory (very needed)
- let you select 'some' items to save (maybe this is before the 'save all'
button is pushed, but anyway...)

Comment 26

[R.K.Aa.]

*** Bug 192699 has been marked as a duplicate of this bug. ***

Comment 27

[Mark B. Elrod]

Is anyone still working on this or is it just stagnant? If noone is working on
it I would be glad to polish the current patch with Kevin Butler's suggestions.

Comment 28

[Andi]

the missing ability to create a directory can't be that hard - for windows os, 
mailnews uses a windows default dialog which has a flag to allow directory 
creation or not. so a patch for windows would be a one-liner, i think.

Comment 29

[Thomas R. (TRauMa)]

All with linux (gtk2)

Update: 1.4 has 
- create directory (see bug #205606)
- default to the last "save as" directory
- let you type a path

Mozilla Mail IMHO needs:
- let you select 'some' items to save (maybe this is before the 'save all'
button is pushed, but anyway...)
- If nothing is selected, take the current dir the dialog browser is in. This
would also fix bug #205606 and would be less strange. With the current behaviour
we have:
*click* Save all...
*click* Create Dir...
*click* Name dir...
*click* leave dir...
*click* select dir...
*click* Save
--------
The next time we get:
*click* leave dir...
*click* select dir...
*click* Save
to save in the very same directory... this is strange, at least.

Comment 30

[Brodie]

For the moment simply enabling multiple select on the attachment listbox would
be satisfactory.

Comment 31

[Andrew Schultz]

The linux and Windows dialogs here are completely different.  see bug 134634 for
linux-specific stuff.

Comment 32

[Aaron Lawrence]

I think this issue is entirely resolved, at least on Win32.

Perhaps I'm missing something, but I believe in both TB and seamonkey (suite) the attachment listbox is multi-select. That addresses the major feature of the original OE dialog.

[On Win32] There is a dialog to select a folder, including a space to type a path, and a button to create a new folder.

http://integration.co.nz/download/SaveMultipleFiles.png

Closing this. 

Comment 33

[Kevin Butler]

I disagree with the choice to close it, but I do agree that the select multiple files & save as is a better UI than the "save all" UI.

Could you change the "save all" button to actually do a "select all" and then open the "save as" dialog with all the attachments selected?

I believe this would address the remaining concerns with the Save As dialog. (See above comments, including one from me, for those concerns.

Comment 34

[Aaron Lawrence]

Kevin, you said:
- default to the last "save as" directory
 - it does
- let you type a path
 - it does
- let you create a directory (very needed)
 - it does
- let you select 'some' items to save (maybe this is before the 'save all'
button is pushed, but anyway...)
 - it does (by selecting items in the listbox).

So I don't see what is remaining. Please clarify.