371182 - antialiasing problems at bevels of border-collapsed borders

Status: VERIFIED FIXED

(Core :: Graphics, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

The borders of border-collapsed tables show the border drawing problems that were fixed elsewhere by the patch in bug 328241 comment 25.

Steps to reproduce: load attachment
Expected results: solid black border around the edge
Actual results: lighter colors visible along the bevels

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes the bug, and also fixes a warning by changing a float to an int (followup to units rewrite).  If this conflicts with your border rewrite, I could hold off, or skip the PaintBorder changes.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 256144 [details] [diff] [review]
patch

Nope, go for it; my stuff just rewrites that function en-masse (and just #includes another file and #if 0's out the others so I don't get conflicts, for now), so it's no problem.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 4

[Jesse Ruderman]

I tried to make a reftest for this, but I couldn't get a border-collapse table with a border to line up with either a normal table or plain div with a border.  Adding borders apparently moves different things in different directions :(

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050704 Minefield/3.0pre.