371187 - pixel rounding of heights causing reftest failures

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Pixel rounding of heights in the table code seems to be causing reftest failures on mac.

reftests/table-width/cellspacing.html
reftests/table-width/percent-basis.html
reftests/table-width/default-box-sizing-separate-standards.html
reftests/table-width/default-box-sizing-separate-quirks.html

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This removes all remaining uses of RoundToPixel, and fixes the first two of the four failures.  I need to look into why the latter two are still happening.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(It's possible the remaining problems are bug 363220.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The problems on the other two testcases are actually bug 361523.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 255986 [details] [diff] [review]
patch

I'd like to remove the rest of the RoundToPixel code, for the same reasons that I removed it in bug 369318 (see bug 369318 comment 3).

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 255986 [details] [diff] [review]
patch

oops

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.