371190 - Some localized builds have broken migration wizards (missing the option to choose a homepage)

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Tony Chung [:tchung]]

Attachment: portal 20 migration window

Repro:
1) open IE, and save a few bookmarks, homepages
2) Download and install the Portal 2.0.0.1 zhTW build.
Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-TW; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
3) blow away your appdata\Mozilla directory
4) run firefox.exe and watch the migration wizard appear.
5) Verify migration wizard is missing the option to choose a startup homepage. 

** See attachment

Expected:
- option should appear to choose Portal homepage or IE homepage options

Actual: 
- The dialog box has no options to choose anything.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This was fixed by the second patch for bug 364297. It affected the zh-TW and ko builds.

Tony, can you verify with a more recent build (2.0.0.2 rc5)?

http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/ko/other-licenses/branding/firefox&command=DIFF_FRAMESET&file=brand.properties&rev1=1.1.2.8&rev2=1.1.2.9&root=/l10n
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/zh-TW/other-licenses/branding/firefox&command=DIFF_FRAMESET&file=brand.properties&rev1=1.4.2.5&rev2=1.4.2.6&root=/l10n

Comment 2

[Tony Chung [:tchung]]

Per discussion with Gavin, I am reactivating this bug because this affects bug affects other locales that may have  a broken migration Wizard.  This was found origially for Portal20/PCHome 2.001 on zh-TW, but could very well affect any builds that have missing strings returned in the import dialog window (both 1.5x and 2.001)


Related bug is bug 371155

Comment 3

[Tony Chung [:tchung]]

This also repros on the Divx 2.0 ko RC1 build. 

Comment 4

[Tim Riley [:timr]]

Attachment: Google ko GooglePack 2.0.0.1

Comment 5

[Tim Riley [:timr]]

Also seen this with the Google GooglePak ja build for 2.0.0.1.  See attachment 2 [details] [diff] [review]

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Basil, timr: Is there any reason for this bug to be Mozilla Corp confidential?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This bug was fixed for 2.0.0.x by bug 371309, and I don't think we're going to be making any changes to the 1.5.0.x builds at this point, so marking this FIXED.

Comment 8

[Tim Riley [:timr]]

(In reply to comment #6)
> Basil, timr: Is there any reason for this bug to be Mozilla Corp confidential?
> 

I think this is marked confidential as it affects how we broke specific partner distros and this had to be communicated to them very carefully.  Best to leave it confidential IMO.

Comment 9

[Tim Riley [:timr]]

(In reply to comment #7)
> This bug was fixed for 2.0.0.x by bug 371309, and I don't think we're going to
> be making any changes to the 1.5.0.x builds at this point, so marking this
> FIXED.
> 
It doesn't look like this is needed for 1.5.0.x.  Tony or Basil- do you disagree?  I vote for marking it fixed.

Comment 10

[Tony Chung [:tchung]]

I'm okay with leaving it fixed for 2.0.0.x only also.   

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> I think this is marked confidential as it affects how we broke specific partner
> distros and this had to be communicated to them very carefully.

As mentioned on IRC, this bug wasn't specific to partner builds, it just happened to be discovered while we were testing them.

Comment 12

[Tony Chung [:tchung]]

Verified fixes on zhTW and ko, 2004.  option now appears in migWiz

Mozilla/5.0 (Windows; U; Windows NT 5.1; ko; rv:1.8.1.4) Gecko/20070501 Firefox/2.0.0.4

Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-TW; rv:1.8.1.4) Gecko/20070501 Firefox/2.0.0.4