"Other languages" list should not require clicking the "Go" button

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
12 years ago
3 years ago

People

(Reporter: gaubugzilla, Assigned: wenzel)

Tracking

Details

(Reporter)

Description

12 years ago
"Other languages" select in the lower right corner of the page should have an onchange attribute to make sure the switch happens instantaneously when the user selects another language:

onchange="location.pathname = location.pathname.replace(/^\/[^\/]+/, '/' + this.value)"

Alernatively:

onchange="this.form.submit()"

The "Go" button can be wrapped inside a <noscript> block to appear only when JavaScript is disabled.
(Assignee)

Comment 1

12 years ago
Yes I agree, automatically doing the switch makes sense.

Removing the "go" button however is a question if we want to make the site differ more from mozilla.com, which also has a button there.
(Reporter)

Comment 2

12 years ago
Fix mozilla.com as well? :)
I like the Go button. :(
Eh, I'm fine with it either way.  I think we should stay consistent with mozilla.com though, and Paul Kim has the call there.

Comment 5

12 years ago
I don't really care either way. But we should be consistent across mozilla.com and mozilla-europe.org as well. Adding Pascal Chevrel to represent Mozilla Europe.
I see no problem doing it on mozilla europe
(Assignee)

Comment 7

12 years ago
Okay, I submitted the change to AMO. The diff is here:

http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/elements/footer.thtml?r1=2274&r2=2285

Please make the appropriate changes to mo.com and m-e.org (or have them made) and put them in the next update cycle.

I keep this bug open for now, until the other projects are patched as well. If you feel this is unnecessary, feel free to close it.

Thanks everybody.
Assignee: nobody → fwenzel
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Sending        includes/footer.inc.php
Sending        includes/functions.inc.php
Transmitting file data ..
Committed revision 2286.

Fixed on trunk for www.mozilla.com. Will go live tomorrow morning.
this change is ready on mozilla europe and will be published with the 2.0.0.2 release
(Assignee)

Comment 10

12 years ago
Great. I call this fixed. Thanks, guys.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.