371193 - "Other languages" list should not require clicking the "Go" button

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[Wladimir Palant]

"Other languages" select in the lower right corner of the page should have an onchange attribute to make sure the switch happens instantaneously when the user selects another language:

onchange="location.pathname = location.pathname.replace(/^\/[^\/]+/, '/' + this.value)"

Alernatively:

onchange="this.form.submit()"

The "Go" button can be wrapped inside a <noscript> block to appear only when JavaScript is disabled.

Comment 1

[Fred Wenzel [:wenzel]]

Yes I agree, automatically doing the switch makes sense.

Removing the "go" button however is a question if we want to make the site differ more from mozilla.com, which also has a button there.

Comment 2

[Wladimir Palant]

Fix mozilla.com as well? :)

Comment 3

[Justin Scott [:fligtar]]

I like the Go button. :(

Comment 4

[Wil Clouser [:clouserw]]

Eh, I'm fine with it either way.  I think we should stay consistent with mozilla.com though, and Paul Kim has the call there.

Comment 5

[Paul Kim]

I don't really care either way. But we should be consistent across mozilla.com and mozilla-europe.org as well. Adding Pascal Chevrel to represent Mozilla Europe.

Comment 6

[Pascal Chevrel:pascalc]

I see no problem doing it on mozilla europe

Comment 7

[Fred Wenzel [:wenzel]]

Okay, I submitted the change to AMO. The diff is here:

http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/elements/footer.thtml?r1=2274&r2=2285

Please make the appropriate changes to mo.com and m-e.org (or have them made) and put them in the next update cycle.

I keep this bug open for now, until the other projects are patched as well. If you feel this is unnecessary, feel free to close it.

Thanks everybody.

Comment 8

[Reed Loden [:reed]]

Sending        includes/footer.inc.php
Sending        includes/functions.inc.php
Transmitting file data ..
Committed revision 2286.

Fixed on trunk for www.mozilla.com. Will go live tomorrow morning.

Comment 9

[Pascal Chevrel:pascalc]

this change is ready on mozilla europe and will be published with the 2.0.0.2 release

Comment 10

[Fred Wenzel [:wenzel]]

Great. I call this fixed. Thanks, guys.