Closed
Bug 371193
Opened 17 years ago
Closed 17 years ago
"Other languages" list should not require clicking the "Go" button
Categories
(addons.mozilla.org Graveyard :: Public Pages, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwkbugzilla, Assigned: wenzel)
Details
"Other languages" select in the lower right corner of the page should have an onchange attribute to make sure the switch happens instantaneously when the user selects another language: onchange="location.pathname = location.pathname.replace(/^\/[^\/]+/, '/' + this.value)" Alernatively: onchange="this.form.submit()" The "Go" button can be wrapped inside a <noscript> block to appear only when JavaScript is disabled.
Assignee | ||
Comment 1•17 years ago
|
||
Yes I agree, automatically doing the switch makes sense. Removing the "go" button however is a question if we want to make the site differ more from mozilla.com, which also has a button there.
Reporter | ||
Comment 2•17 years ago
|
||
Fix mozilla.com as well? :)
Comment 3•17 years ago
|
||
I like the Go button. :(
Comment 4•17 years ago
|
||
Eh, I'm fine with it either way. I think we should stay consistent with mozilla.com though, and Paul Kim has the call there.
I don't really care either way. But we should be consistent across mozilla.com and mozilla-europe.org as well. Adding Pascal Chevrel to represent Mozilla Europe.
Comment 6•17 years ago
|
||
I see no problem doing it on mozilla europe
Assignee | ||
Comment 7•17 years ago
|
||
Okay, I submitted the change to AMO. The diff is here: http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/elements/footer.thtml?r1=2274&r2=2285 Please make the appropriate changes to mo.com and m-e.org (or have them made) and put them in the next update cycle. I keep this bug open for now, until the other projects are patched as well. If you feel this is unnecessary, feel free to close it. Thanks everybody.
Assignee: nobody → fwenzel
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 8•17 years ago
|
||
Sending includes/footer.inc.php Sending includes/functions.inc.php Transmitting file data .. Committed revision 2286. Fixed on trunk for www.mozilla.com. Will go live tomorrow morning.
Comment 9•17 years ago
|
||
this change is ready on mozilla europe and will be published with the 2.0.0.2 release
Assignee | ||
Comment 10•17 years ago
|
||
Great. I call this fixed. Thanks, guys.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•