371209 - Additem quotes problems

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Justin Scott [:fligtar]]

Add-ons with quotes in their names and other install.rdf properties have some issues with the submission process.

Comment 1

[Shawn Wilsher :sdwilsh]

I'm not sure if this is the same bug, but just about all the fields will have slashes in them before quotes if you have an error or try to edit your extension's data.

Comment 2

[carglue a t ya hoo do tcom]

This may also be related.. the "Edit Preview" page (for images and their captions) does not allow single quotes in the caption field.  Trying to use them will result in no caption being posted. 

Comment 3

[Mike Shaver (:shaver emeritus)]

I think this is fixed now.

Comment 4

[Justin Scott [:fligtar]]

Don't know why you'd think that!

Comment 5

[Fred Wenzel [:wenzel]]

Actually, the "edit preview" quotes issue was indeed fixed a long time ago -- the install.rdf issue is still open though, but I am looking into it.

Comment 6

[Michael Morgan [:morgamic]]

Fred, any progress on the install.rdf issue?

Comment 7

[Fred Wenzel [:wenzel]]

Attachment: patch to remove quotes before publish()ing data

As a matter of fact yes, there is. I managed to find a solution that does not require us to stop cleaning user data globally (which would have bad security implpications).

Instead I am removing the quotes just for the view, using a slightly extended unclean() function.

I will also attach a teeny example xpi which will have quotes problems with the current AMO but not with this patch.

Morgamic, please approve :)

Comment 8

[Fred Wenzel [:wenzel]]

Attachment: simple xpi containing quotes

This is a simple test xpi containing just an install.rdf with some quotes in it.

Comment 9

[Michael Morgan [:morgamic]]

Comment on attachment 279782 [details] [diff] [review]
patch to remove quotes before publish()ing data

Looks good, since all it does is unslash.

Comment 10

[Fred Wenzel [:wenzel]]

Alright, this is committed to the trunk, r6594. Marking this FIXED.

It will go online with the next push.