37140 - Find Again is always enabled

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[laurel]

Using apr21-24 commercial m16 builds all platforms

Search|Find Again is always enabled.  It should only enable after previous find
has been engaged and/or find criteria is preserved in dialog (to use in Find
Again).

1.  Launch Netscape.
2.  Check Search menu... Find Again is enabled. It shouldn't be.

Happens same in browser, mail window or standalone message window.

Comment 1

[Claudius Gayle]

I know it sounds silly but Find*Search, really. Qa to sairuh so she can find the right person to reassign to. changing component to 
xpapps altohugh this might be a menu thing

Comment 2

[sairuh (rarely reading bugmail)]

over to simon...

Comment 3

[R.K.Aa.]

*** Bug 38000 has been marked as a duplicate of this bug. ***

Comment 4

[rubydoo123]

command updating bug, setting correctness keyword

Comment 5

[rubydoo123]

setting to nsbeta3+

Comment 6

[rubydoo123]

adding the brackets in the status

Comment 7

[rubydoo123]

setting priority in status whiteboard

Comment 8

[rubydoo123]

talked with Simon about this one, this should really go over to Bill since it is 
across the entire app

Comment 9

[johng]

nav triage team:
nsbeta3+ because it is part of top level UI in each component.

A fix could be "disable" or could be that the "Find Again" just opens the Find
dialog - either solution is OK.

Comment 10

[Bill Law]

Marking P1.

Comment 11

[leger]

Low profile polish. Moving to P3.  Adding [PDTP3]

Comment 12

[Bill Law]

Attachment: proposed fix

Comment 13

[Bill Law]

I've attached this patch; it causes "Find Again" to behave like "Find" in the 
case where we haven't done a search yet in this option.  I.e., it will open the 
Find dialog.  Looking for review...

Index: src/nsFindComponent.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/find/src/nsFindComponent.cpp,v
retrieving revision 1.48
diff -r1.48 nsFindComponent.cpp
874d873
< 		// For now, just record request to console.
875a875,880
> 
>         // If we haven't searched yet, put up dialog (via Find).
>         if ( context->mSearchString.IsEmpty() ) {
>             return this->Find( aContext, aDidFind );
>         }
> 

Comment 14

[Blake Ross]

r=blake, assuming that we want to show the find dialog here instead of 
disabling the item (like what happens when you click Save rather than Save 
As... but haven't yet specified a filename).  I agree that this is the best 
solution for this release, at least.  Nice job.

Comment 15

[Matthew T (active 1999-2002)]

As long as you don't close the bug on the basis of checking that in ... Because 
correct behavior would be to disable the item, not open the dialog. This should 
just be a temporary fix, otherwise the appearance of `Find Again' will lose its 
usefulness as an indicator of `have I tried to find anything before?'.

Comment 16

[Blake Ross]

I think this fix should be checked in, and then this bug be made nsbeta3-
/future so we can address it after 6.0

Comment 17

[Blake Ross]

Bill: Might wanna check it in before it comes minus...

Comment 18

[Bill Law]

Fixed.

Comment 19

[sairuh (rarely reading bugmail)]

so, as it currently stands, if Find wasn't previously used (ie, its textfield
empty), Find Again now brings up the Find dialog.

vrfying using 2000.09.15.08/9 opt comm bits on linux, mac and winnt.