[mac] space should activate buttons on-key-down

ASSIGNED
Assigned to

Status

()

Core
XUL
ASSIGNED
11 years ago
11 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9alpha3
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

On OS X, pressing the space key should activate buttons  immediately (on-key-down)
Created attachment 256206 [details] [diff] [review]
patch
Attachment #256206 - Flags: superreview?(neil)
Attachment #256206 - Flags: review?(enndeakin)

Comment 2

11 years ago
Comment on attachment 256206 [details] [diff] [review]
patch

Won't this mean that the button gets stuck in :hover:active state if the click does anything interesting?
Attachment #256206 - Flags: superreview?(neil) → superreview-
yeah, I was able reproduce that sort of brokenness in the profile manager. :-/

Comment 4

11 years ago
Oh, and this will also break checkboxes, which expect to be able to update the checked state before the command event fires.
Created attachment 256214 [details] [diff] [review]
patch

Hrm, the checked state is supposed to be set onmousedown (on mac anyway).
Attachment #256206 - Attachment is obsolete: true
Attachment #256206 - Flags: review?(enndeakin)
You need to log in before you can comment on or make changes to this bug.