Open Bug 371422 Opened 17 years ago Updated 2 years ago

[mac] space should activate buttons on-key-down

Categories

(Core :: XUL, defect)

PowerPC
macOS
defect

Tracking

()

mozilla1.9alpha3

People

(Reporter: asaf, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

On OS X, pressing the space key should activate buttons  immediately (on-key-down)
Attached patch patch (obsolete) — Splinter Review
Attachment #256206 - Flags: superreview?(neil)
Attachment #256206 - Flags: review?(enndeakin)
Blocks: 309201
Comment on attachment 256206 [details] [diff] [review]
patch

Won't this mean that the button gets stuck in :hover:active state if the click does anything interesting?
Attachment #256206 - Flags: superreview?(neil) → superreview-
yeah, I was able reproduce that sort of brokenness in the profile manager. :-/
Oh, and this will also break checkboxes, which expect to be able to update the checked state before the command event fires.
Attached patch patchSplinter Review
Hrm, the checked state is supposed to be set onmousedown (on mac anyway).
Attachment #256206 - Attachment is obsolete: true
Attachment #256206 - Flags: review?(enndeakin)
on-key-down.
Assignee: asaf → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: