371450 - nsFrame::IsContainingBlock should use nsStyleDisplay::IsBlockInside

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In bug 9458 comment 87, bzbarsky wrote:
> >@@ -3773,6 +3773,7 @@ nsFrame::IsFrameTreeTooDeep(const nsHTML
> >   // Absolute positioning causes |display->mDisplay| to be set to block,
> >   // if needed.
> >   return display->mDisplay == NS_STYLE_DISPLAY_BLOCK || 
> >+         display->mDisplay == NS_STYLE_DISPLAY_INLINE_BLOCK || 
> >          display->mDisplay == NS_STYLE_DISPLAY_LIST_ITEM ||
> >          display->mDisplay == NS_STYLE_DISPLAY_TABLE_CELL;
> 
> Huh.  The function name in that "@@ .... @@" line is such a lie!
> 
> Should the condition here basically be something like IsBlockInside()?

Comment 1

[Mats Palmgren (inactive)]

I can't find any IsContainingBlock function, and I'm removing IsBlockInside in bug 1574107 since it's dead code.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The code is probably now nsIFrame::GetContainingBlock, which calls GetNearestBlockContainer, which has tests for things that aren't containing blocks.

So I think this is no longer an issue.