371481 - [FIX]should nsMathMLmathInlineFrame be eBidiInlineContainer ?

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While working on bug 341326 (see bug 341326 comment 3) I discovered that nsMathMLmathInlineFrame (which inherits from nsInlineFrame) does not claim to be eBidiInlineContainer type (added in bug 169139).  Is this intended, or should it inherit the bit from its base class?

If it's intended, the XXX comment I'm adding in bug 341326 should be removed (and perhaps replaced with a better explanation).  If it's not, the overriding should be removed.

Comment 1

[Uri Bernstein]

It's not intended - not by me, anyway.

You might want to confirm this with Boris, who implemented nsMathMLmathInlineFrame::IsFrameOfType() in bug 322625.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Uh, yeah.  That was a mistake.  The bit should be inherited, imo.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove overriding

Comment 4

[rbs]

I am not able to access bug 322625. What was that bug fixing?!? I am finding increasingly inconvenient not to be able to immediately access such critical background on issues. Crucially too, it also means that I don't learn anything and can repeat the flaw. Can you guys who are on the security group bring this matter up? What will in fact suits me would be to have an intermediate "security-bugs" for folks like myself who are quite interested in having a secure Gecko codebase, without being interested (or having the cycles) to discuss the wide-ranging "security-group" politics.

Passing the sr request to dbaron since I don't know the whereabouts of this bug.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> I am not able to access bug 322625.

You should be able to now....

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er.. and you should have been able to all along, since you were already cced on it.  Unless you weren't logged in?

Comment 7

[rbs]

I attempted but it didn't go (it gives the "you must login first" message anyway). But it works okay now -- not sure if the fact that I am behind a proxy played a trick.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Huh.  When did this get sr?  I guess I wasn't the requestee, so I didn't get bugmail...

In any case, checked in.

Comment 9

[Jeff Walden [:Waldo]]

No idea how/whether effects of this are visible, assuming they are for now...

Comment 10

[Boris Zbarsky [:bzbarsky]]

I think they should be, but I don't know enough about BiDi to create a testcase. :(

Comment 11

[Simon Montagu :smontagu]

I don't see any text at all in MathML elements in current trunk builds in http://www.mozilla.org/projects/mathml/start.xhtml http://www.mozilla.org/projects/mathml/start-hebrew.xhtml or http://www.mozilla.org/projects/mathml/start-thai.xhtml , so it's a little hard to create a testcase right now :(

Comment 12

[Boris Zbarsky [:bzbarsky]]

That would be bug 324857, I guess.  :(