Closed Bug 371495 Opened 17 years ago Closed 15 years ago

Consider preventing themes and/or locales from providing an aboutURL and optionsURL

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: robert.strong.bugs, Assigned: mossop)

Details

Attachments

(1 file, 1 obsolete file)

patch rev 2
5.50 KB, patch
robert.strong.bugs
: review+
benjamin
: approval1.9.2+
Details | Diff | Splinter Review
Product: Firefox → Toolkit
Why would we do this?
aboutURL requires XUL and theme's aren't allowed to provide XUL. iirc the default about page for a theme that does this will not be displayed if it provides an aboutURL.
Right, misread it as updateURL for some reason
Target Milestone: --- → mozilla1.9.2
Summary: Consider preventing themes from providing an aboutURL → Consider preventing themes and/or locales from providing an aboutURL and optionsURL
Attached patch patch rev 2 — — Splinter Review 
Updated patch, covers aboutURL and optionsURL and includes a testcase.
Assignee: nobody → dtownsend
Attachment #256944 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #395028 - Flags: review?(robert.bugzilla)
Attachment #395028 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/567f5aa9792f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs baking]
Target Milestone: mozilla1.9.2 → mozilla1.9.3a1
Comment on attachment 395028 [details] [diff] [review]
patch rev 2

This stops themes and locales from attempting to provide UI that they shouldn't be able to. It has tests and is very low risk.
Attachment #395028 - Flags: approval1.9.2?
Whiteboard: [needs baking]
Attachment #395028 - Flags: approval1.9.2? → approval1.9.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: