371567 - Seamonkey should show favicons in bookmarks menu

Status: RESOLVED WORKSFORME

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[jesse]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 Mnenhy/0.7.4.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 Mnenhy/0.7.4.0

Bookmark pulldown menu in Seamonkey 1.1 uses default bookmark icon even for bookmarked sites that utilize favicons.

Reproducible: Always

Steps to Reproduce:
1.Crtl+B or click on bookmarks menu


Actual Results:  
notice lack of favicons

Expected Results:  
next to bookmark text should be site favicon

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

In about:config, what are your values for these?

browser.chrome.site_icons

browser.chrome.favicons

Are you saying this is broken, or you have those defaulted to "false," and you'd like to see the default flipped?  The last I heard from the SeaMonkey Council was that these were a performance hit.

Comment 2

[jesse]

I had those values at true and false respectively - which I assume is default.  Changing browser.chrome.favicons to true did not seem to resolve this issue.  

Would the alleged performance hit be a peristant memory usage issue or just slower load time for bookmark listing?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
 <snip>
 
> Would the alleged performance hit be a peristant memory usage issue or just
> slower load time for bookmark listing?

There was some backlash from server admins who found that favicon-seeking was making too many calls; I can't remember if this has subsequently been addressed.  Memory is probably not the issue, nor, really, a slower load time, unless your bookmarks list is huge. 

Comment 4

[Serge Gautherie (:sgautherie)]

Can you reproduce with SeaMonkey v1.1.9 ?

Comment 5

[jesse]

>Can you reproduce with SeaMonkey v1.1.9 ?

yes.  the default is still to not have favicons show in the bookmarks menu.  I did manage to eventually change this somehow, though the method escapes me now. I'm running on an older system and saw no changes in memory usage or subjective performance.  I still believe favicons should show in the bookmarks by default.

Comment 6

[OstGote!]

(In reply to comment #5)
> I still believe favicons should show in the bookmarks by default.

Then this report should be an enhancement (other defaults, perhaps GUI), not a bug. The prefs are already there.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Favicons are stored persistently with bookmarks in the Places back-end which powers SM 2.1pre. You can verify that using e.g. SM 2.1b1. Marking WFM.

Comment 8

[[e-mail]]

The preference for SeaMonkey 2.0 and earlier is

browser.chrome.load_toolbar_icons

0 = Don't load icons (default)
1 = Show icons of recently visited pages
2 = Aggressively load icons