371647 - ConvertToUnicode in mailWidgets.xml fails at initializing the notification

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIScriptableUnicodeConverter.ConvertToUnicode]" 
nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://messenger/content/mailWidgets.xml :: parseFolder :: line 2114"  data: no]
Source File: chrome://messenger/content/mailWidgets.xml
Line: 2114

> 2111                 var previewText = msgHdr.getStringProperty('preview');
> 2112                 // convert the preview text from utf-8 to unicode          
> 2113                 if (previewText)            
> 2114                   msgPopup.setAttribute('previewText',
unicodeConverter.ConvertToUnicode(previewText));

Maybe, this error is occurred at coming the wrong mail that doesn't have a valid charset for content-type. (many spam mails have it!)

I sometimes reproduce that the notification window never appear. Probably, this bug causes it.

I think that this should be fixed on tb2.

Comment 1

[Scott MacGregor]

If convertToUnicode throws an error should we:

* not set the preview text attribute (like this patch)
* use the unconverted preview text (would this ever show something useful?)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #1)
> If convertToUnicode throws an error should we:
> 
> * not set the preview text attribute (like this patch)
> * use the unconverted preview text (would this ever show something useful?)

We should not use broken text. Because the broken text rendering is too slow, especially on trunk.

Comment 3

[Scott MacGregor]

Comment on attachment 256378 [details] [diff] [review]
Patch rv1.0

Thanks Masayuki.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 5

[Scott MacGregor]

flag cleanup.