remove nsIInspectorCSSUtils

RESOLVED FIXED in mozilla1.9.2b1

Status

()

Core
CSS Parsing and Computation
P4
normal
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.9.2b1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

11 years ago
nsIInspectorCSSUtils was created to allow code in extensions/inspector to get access to some layout internals.  That code is now in layout/inspector, so it has access to layout internals without the interface, which is now unneeded.  It should be removed.
(Assignee)

Updated

11 years ago
Version: 1.8 Branch → Trunk
(Assignee)

Updated

11 years ago
Assignee: dbaron → nobody
QA Contact: ian → style-system
(Assignee)

Comment 1

9 years ago
Created attachment 393392 [details] [diff] [review]
part 1:  Move GetStyleContextForContent to nsComputedDOMStyle
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #393392 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

9 years ago
Created attachment 393393 [details] [diff] [review]
part 2: Move remaining substantive code to inDOMUtils
Attachment #393393 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

9 years ago
Created attachment 393394 [details] [diff] [review]
part 3: Remove the trivial methods and replace their callers with appropriate internal calls
Attachment #393394 - Flags: review?(bzbarsky)
(Assignee)

Comment 4

9 years ago
Created attachment 393395 [details] [diff] [review]
part 4: Remove nsIInspectorCSSUtils and nsInspectorCSSUtils
Attachment #393395 - Flags: review?(bzbarsky)
(Assignee)

Comment 5

9 years ago
In part 2, I just noticed I forgot to reindent inDOMUtils::GetRuleNodeForContent to sw=2 rather than sw=4; now fixed locally.
Attachment #393392 - Flags: review?(bzbarsky) → review+
Attachment #393393 - Flags: review?(bzbarsky) → review+
Attachment #393394 - Flags: review?(bzbarsky) → review+
Attachment #393395 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

9 years ago
http://hg.mozilla.org/mozilla-central/rev/70190028e932
http://hg.mozilla.org/mozilla-central/rev/753538af64b3
http://hg.mozilla.org/mozilla-central/rev/1be3195ec1c2
http://hg.mozilla.org/mozilla-central/rev/9c54fecf8cfc
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
You need to log in before you can comment on or make changes to this bug.