mxr claims G_PreferenceObserver.prototype.QueryInterface has an error

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: timeless, Assigned: Tony Chang (Google))

Tracking

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
load:
http://mxr.landfill.bugzilla.org/seamonkey/source/toolkit/components/url-classifier/content/moz/preferences.js#302

note that *almost* everything in this blob:
 294 /**
 295  * XPCOM cruft
 296  *
 297  * @param iid Interface id of the interface the caller wants
 298  */
 299 G_PreferenceObserver.prototype.QueryInterface = function(iid) {
 300   var Ci = Ci;
 301   if (iid.equals(Ci.nsISupports) || 
 302       iid.equals(Ci.nsIObserves) ||
 303       iid.equals(Ci.nsISupportsWeakReference))
 304     return this;
 305   throw Components.results.NS_ERROR_NO_INTERFACE;
 306 }
is linked. except nsIObserves. That probably means it's wrong :)
(Assignee)

Comment 1

11 years ago
Created attachment 256514 [details] [diff] [review]
nsIObserves -> nsIObserver

Thanks, this should be nsIObserver.
Assignee: nobody → tony
Status: NEW → ASSIGNED
Attachment #256514 - Flags: review?(timeless)
(Reporter)

Updated

11 years ago
Attachment #256514 - Flags: review?(timeless) → review+
(Assignee)

Comment 2

11 years ago
on trunk

Checking in preferences.js;
/cvsroot/mozilla/toolkit/components/url-classifier/content/moz/preferences.js,v  <--  preferences.js
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.