Add-ons manager buttons doesn't fit with new Highlight color

RESOLVED WONTFIX

Status

()

--
minor
RESOLVED WONTFIX
12 years ago
9 years ago

People

(Reporter: stefanh, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
PowerPC
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

12 years ago
I don't think the buttons in AM fit very well with the new "Highlight" color. I guess I was wrong about the mozapps/extensions/extensions.css styles in bug 371646, comment #1.
(Reporter)

Comment 1

12 years ago
Created attachment 256469 [details]
Screenshot of Add-ons manager
(Reporter)

Comment 2

12 years ago
Actually, this is a general issue with the buttons in the first row. For some reason they're transparent. Hmm.
(Reporter)

Comment 3

12 years ago
Created attachment 256472 [details]
Screenshot, non-disabled buttons

(In reply to comment #2)
> Actually, this is a general issue with the buttons in the first row. For some
> reason they're transparent. Hmm.

OK, disabled buttons becomes transparent. Not really the background-colors fault. Anyway, I'll leave it up to some ui-person to decide if this really is a bug. Attaching a screenshot of how it looks with an installed theme where the author has a "lot" to say.

Comment 4

12 years ago
Last time I looked the problem isn't transparent buttons. The problem is that the font color is wrong.

Comment 5

12 years ago
I just tested some more and I don't think there is a bug. The font color problem I mentioned is from another patch of mine that hasn't landed. I don't see any bug here.
focused and pressed states are kinda ugly too.

Fix is to use bevel buttons IMHO.
Flags: blocking-firefox3?
(Reporter)

Comment 7

12 years ago
Created attachment 256623 [details] [diff] [review]
Use bevel-buttons

Try and see how this looks. A child selector is more appropiate (and less expensive).
Attachment #256623 - Flags: review?(mano)
(Reporter)

Comment 8

12 years ago
Created attachment 256662 [details]
Screenshots of patched AM
(Reporter)

Comment 9

12 years ago
Comment on attachment 256623 [details] [diff] [review]
Use bevel-buttons

Mano thought it looked odd with the bevel buttons.
Attachment #256623 - Flags: review?(mano)
Huh? you got that wrong. The bevel buttons are an improvement imo (may want to do that as well, here or in a follow-up), they don't help with this odd transparency issue though.
(Reporter)

Comment 11

12 years ago
(In reply to comment #10)
> Huh? you got that wrong. The bevel buttons are an improvement imo (may want to
> do that as well, here or in a follow-up), they don't help with this odd
> transparency issue though.
> 

OK. The transparency exists on branch too. Might be that buttons aren't expected to be anywhere else than in a dialog/window with it's standard background. You can't use background-color on native styled stuff either. Hmm.
(Reporter)

Comment 12

11 years ago
I was looking at this for some time ago, but forgot to comment here. It seems that all native-styled buttons are slight transparent when disabled. Imo the manager should probably be re-worked - those buttons should have their own box so they don't blend in with the background-color. I must say that even enabled buttons tend to drown a bit in the background (probably on other OS as well).

Other than that, I can just think of non-optional solutions:
- use another, hard-coded color for highlighted items
- use "-moz-appearance: none;" on the buttons and try to mimic native buttons 
- add a wrapper (hbox?) around each button (bevel button) and give that wrapper a different background-color (like -moz-field or something).
(Reporter)

Comment 13

11 years ago
(In reply to comment #12)

> I must say that even enabled
> buttons tend to drown a bit in the background (probably on other OS as well).

Not really sure why I said that, but I guess I was thinking of  (picturing) a situation where you had your selection color set to a color similar to that of a button's background color.
Not a blocker, not even sure that it's still a bug (Josh?). The bevelled buttons don't match with any other buttons in the UI, so I don't think we'd go that way.
Flags: blocking-firefox3? → blocking-firefox3-
(Reporter)

Comment 15

11 years ago
(In reply to comment #14)
> Not a blocker, not even sure that it's still a bug (Josh?). The bevelled
> buttons don't match with any other buttons in the UI, so I don't think we'd go
> that way.
> 

Actually, there is a bevelled button in the Downloads window ;-)
(Assignee)

Updated

10 years ago
Product: Firefox → Toolkit

Updated

9 years ago
Severity: normal → minor
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.