JS Error when opening .EML file

VERIFIED FIXED

Status

Thunderbird
Mail Window Front End
--
minor
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Mike Cowperthwaite, Assigned: Scott MacGregor)

Tracking

({fixed1.8.1.3, regression})

fixed1.8.1.3, regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

602 bytes, patch
Scott MacGregor
: review+
Scott MacGregor
: superreview+
Scott MacGregor
: approval-thunderbird2+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Bug 358121 fixed a similar problem by adding a try/catch around the line
  folder = aUrl.folder;
but the line immediately after includes a test for null 'folder' before testing for the foldertype being 'nntp' or 'rss' -- because 'folder' is null, when you open a .EML file.

Bug 328749 replaced that code with a rewrite; the analogous try/catch block was maintained in the new code, but the null-folder check was not.  This is now causing an error every time you open a .EML file.  That's what this bug is about.


Bug 358247 ported the 358121 code to Seamonkey and put the test within the try block, allowing the null check to be discarded.  Seamonkey is still running with the older code.  (Is it really necessary that this file is forked?)
(Reporter)

Comment 1

11 years ago
xref bug 358121 comment 5
OS: Windows 2000 → All
Hardware: PC → All
Version: Trunk → 2.0
(Reporter)

Comment 2

11 years ago
Created attachment 256488 [details] [diff] [review]
diff -uw vs. 2b2-0221 distro

This fixes the problem by moving the test inside the try block, per Neil's comment.  This fixes the bug and re-allows the .EML file to be detected as a scam, altho the "Not a Scam" button does nothing when clicked in that case.  Maybe it should be disabled.
(Reporter)

Updated

11 years ago
Attachment #256488 - Flags: superreview?(mscott)
Attachment #256488 - Flags: review?(mscott)
(Reporter)

Comment 3

11 years ago
Created attachment 256490 [details] [diff] [review]
diff -u  

Sorry, I'm an idiot; you don't need a whitespace patch here.
Attachment #256488 - Attachment is obsolete: true
Attachment #256490 - Flags: superreview?(mscott)
Attachment #256490 - Flags: review?(mscott)
Attachment #256488 - Flags: superreview?(mscott)
Attachment #256488 - Flags: review?(mscott)
(Assignee)

Comment 4

11 years ago
Comment on attachment 256490 [details] [diff] [review]
diff -u  

thanks Mike.
Attachment #256490 - Flags: superreview?(mscott)
Attachment #256490 - Flags: superreview+
Attachment #256490 - Flags: review?(mscott)
Attachment #256490 - Flags: review+
Attachment #256490 - Flags: approval-thunderbird2+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.3
Resolution: --- → FIXED
(Reporter)

Comment 5

11 years ago
V with TB 2.0pre-0227, Win2K.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.