37180 - [i18n] MsgComposeCommands.js should use nsIFilePicker instead of nsIFileSpecWithUI

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Frank Tang]

You should move your code from nsIFileSpecWithUI to nsIFilePicker. Also, please 
use the wstring version of the function in the nsILocalFile in javascript but 
not the string version  of function. 
Please do not hard code string "Enter file to attach" neither. This will cause 
localizablility issue.


863 function AttachFile()
864 {
865         dump("AttachFile()\n");
866         currentAttachment = "";
867 
868         // Get a local file, converted into URL format
869         try {
870                 var filePicker = 
Components.classes["component://netscape/filespecwithui"].createInstance();
871                 filePicker = 
filePicker.QueryInterface(Components.interfaces.nsIFileSpecWithUI);     
872                 currentAttachment = filePicker.chooseFile("Enter file to 
attach");
873         }
874         catch (ex) {
875                 dump("failed to get the local file to attach\n");
876         }
877         
878         AddAttachment(currentAttachment);
879 }
880

Comment 1

[(not reading, please use [e-mail] instead)]

i18n bug.  re-assign to ducarroz, who owns compose.

Comment 2

[Jean-Francois Ducarroz]

reassign to jefft.

Comment 3

[jefft]

Sorry, I don't do nsIFilePicker stuff. I refuse to take it. Why me?

Comment 4

[Jean-Francois Ducarroz]

Because I will be on vacation at the end of this week and therefore I wont be 
able to take care of it until June 10th. I did reassign it to you as, correct me 
if I am wrong, you did the original implementation of attach file in MsgCompose.

Comment 5

[scottputterman]

reassigning to ducarroz and cc'ing jefft.  I know it's not selmer who owns this!
 Jean-Francois, if this is your bug then we can wait until you are back from
vacation.  Jefft, if this is your bug because you own the implementation of the
attach dialog, then please take it.

Comment 6

[scottputterman]

nominating for nsbeta2

Comment 7

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 8

[scottputterman]

reassigning to Varada.

Comment 9

[varada]

Marking fixed.

Comment 10

[varada]

Trying a second time to commit as marking fixed.

Comment 11

[lchiang]

frank - can you help to verify this?

Comment 12

[lchiang]

Ok, I will attempt to verify this.  The AttachFile function is now in 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/MsgCo
mposeCommands.js#1267.  

We are now using nsIFilePicker.  I also searched through this file for all 
instances of nsIFileSpecWithUI and it's not found.

1267 function AttachFile()
   1268 {
   1269         dump("AttachFile()\n");
   1270         currentAttachment = "";
   1271         //Get file using nsIFilePicker and convert to URL
   1272     try {
   1273                         var fp = 
Components.classes["component://mozilla/filepicker"].createInstance(nsIFilePicke
r);
   1274                         fp.init(window, 
Bundle.GetStringFromName("chooseFileToAttach"), nsIFilePicker.modeOpen);
   1275                         fp.appendFilters(nsIFilePicker.filterAll);
   1276                         if (fp.show() == nsIFilePicker.returnOK) {
   1277                         currentAttachment = fp.fileURL.spec;
   1278                         dump("nsIFilePicker - "+currentAttachment+"\n");
   1279                         }
   1280     }   
   1281         catch (ex) {
   1282                 dump("failed to get the local file to attach\n");
   1283         }

Comment 13

[lchiang]

Note: I didn't verify the functionality of the attach file dialog; I only 
verified that the code has been changed.  Verification of the attach dialog is 
covered in our UI/functional testing.

Comment 14

[Jean-Francois Ducarroz]

good job Lisa. Can we now reassign some bug to you as your looks like very famillar with Javascript and our code 
base?