371806 - [proto] It's not possible to create recurring event and/or task

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Omar Bajraszewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: 

It's impossible to create a repeating event/task

Reproducible: Always

Steps to Reproduce:
1.Start new profile and install lightning-wcap.xpi (26/02/07)
2.Try to create an event repeating weekly

Actual Results:  
It's impossible

Comment 1

[Stefan Sitter [:ssitter]]

Is there an error message? What is the regression range?

I think it might be the same issue as in Bug 370425 but with a failure in the proto dialog.

Comment 2

[Omar Bajraszewski]

Works with 21/02/2007  (mozilla 1.8)
Fails with 22/02/2007  (mozilla 1.8)

I can't see any errors

Comment 3

[Michael Büttner (no reviews TFN)]

Error: calRecurrenceRule is not defined
Source File: chrome://calendar/content/sun-calendar-event-dialog-recurrence.xml
Line: 467

This is indeed the same issue as with bug 370425, taking this one.

Comment 4

[Stefan Sitter [:ssitter]]

Retest: Still exists in wcap enabled Lightning/0.5pre (2007030404) after checkin for Bug 370425.

Error: calRecurrenceRule is not defined
Source File: chrome://calendar/content/sun-calendar-event-dialog.js 
Line: 2055

Comment 5

[Michael Büttner (no reviews TFN)]

(In reply to comment #4)
> Retest: Still exists in wcap enabled Lightning/0.5pre (2007030404) after
> checkin for Bug 370425.
sorry, i didn't make myself clear with the statement in comment #3. i was referring to the fact that this again this is a regression from bug #366560. specifically, the prototype event dialog also uses 'calIRecurrenceRule' which now should be 'Ci.calIRecurrenceRule'.

Comment 6

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

this patch addresses the necessary modification in order to resolve the conflicts introduced from bug #366560.

Comment 7

[Michael Büttner (no reviews TFN)]

Checked in on trunk and MOZILLA_1_8_BRANCH

Comment 8

[Omar Bajraszewski]

Is the patch available for today build (2007030803)? I can't still create repeating event.

Comment 9

[Stefan Sitter [:ssitter]]

Failure confirmed with Lightning/0.5pre (200703080309) when using on of the default rules. Creating repeating event via custom rule is possible.

Error: calRecurrenceRule is not defined
Source File: chrome://calendar/content/sun-calendar-event-dialog.js
Line: 2055

Comment 10

[Stefan Sitter [:ssitter]]

Attachment: rev0 - fix event dialog too

Use createRecurrenceRule() helper method from Bug 370425.

Comment 11

[Michael Büttner (no reviews TFN)]

Comment on attachment 258471 [details] [diff] [review]
rev0 - fix event dialog too

Thanks a lot for the patch, Stefan.

Comment 12

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 13

[Omar Bajraszewski]

Verified with 20070316 version