371846 - Kill unneccesary ownership management code in nsBindingManager::SetAnonymousNodesFor

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

nsBindingManager::SetAnonymousNodesFor currently checks if any insertion points in the old list exists in the new list before killing the old list. This isn't needed any more since insertion points are refcounted.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 256536 [details] [diff] [review]
Patch to fix

So this is basically backing out part of bug 296375. That bug has a testcase. r=me

Comment 2

[Nickolay_Ponomarev]

Should this be checked in?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, I need to test it using the testcases in bug 296375 first though.

If you wanna convert them into mochikit tests that'd save me that effort ;)

Comment 4

[Nickolay_Ponomarev]

There's a single usable testcase there, your patch doesn't seem to regress that. I can make it a mochitest, yes.

Comment 5

[Nickolay_Ponomarev]

Attachment: auto-test from 296375

Crashes with an old 1.0+ build, doesn't crash in a patched current trunk build, nor in 2.0.

Comment 6

[Nickolay_Ponomarev]

er, actually it crashes in the 1.0+ build only if you remove the 'type="application/javascript"', which the old build for some case didn't like.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in.

Nickolay: thanks for helping out by helping writing the testcase.

Comment 8

[Nickolay_Ponomarev]

http://lxr.mozilla.org/mozilla/source/content/xbl/test/test_bug296375.xul