Cleanup layout reftest lists

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Created attachment 256567 [details] [diff] [review]
Clean up the layout reftests

Attached is a patch which sorts all of the layout reftests by bug number and alphabetically when necessary.
Attachment #256567 - Flags: superreview?(dbaron)
Attachment #256567 - Flags: review?(dbaron)
So in many cases the order was semantic -- starting with easier tests and moving to harder tests.  I think the only ones that should be sorted are the bugs, and just by bug number (leaving the current order within bugs).  And at the same time we should probably create a reftest.list in the bugs/ subdirectory and include it in the one above.
Attachment #256567 - Flags: superreview?(dbaron)
Attachment #256567 - Flags: superreview-
Attachment #256567 - Flags: review?(dbaron)
Attachment #256567 - Flags: review-
(Assignee)

Comment 2

12 years ago
Created attachment 256738 [details] [diff] [review]
Sort only bug reftests and move them to separate list

Like so?
Attachment #256567 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Attachment #256738 - Flags: superreview?(dbaron)
Attachment #256738 - Flags: review?(dbaron)
Comment on attachment 256738 [details] [diff] [review]
Sort only bug reftests and move them to separate list

Yep, looks good.  r+sr=dbaron.

Do you need someone to land this for you?
Attachment #256738 - Flags: superreview?(dbaron)
Attachment #256738 - Flags: superreview+
Attachment #256738 - Flags: review?(dbaron)
Attachment #256738 - Flags: review+
Assignee: nobody → ryanvm
Checked in to trunk.  (I also added a comment at the top saying to keep it sorted by bug number.)

Thanks for the patch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 5

12 years ago
For the record, the object/ tests were sorted by the ordering found at their original location on biesi's site, so not rearranging them was the right thing to do.  :-)  I dislike opaque numbers, tho, so I tried to give them meaningful names to aid in guessing what they do if any one were to fail in the future.
and I did try to list simpler tests first, more complex tests later there.
You need to log in before you can comment on or make changes to this bug.