371956 - Problems with linkification of channel names

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Matthew Gertner]

Channel names should only be linkified if the string starts with a #. Right now something like @#foo gets linkified. Also, channel names can't contain commas according to RFC 1459.

Comment 1

[:Gijs (he/him)]

Please don't change the assignee without CC-ing the default. It means a number of people don't get bugmail, which sucks.

Comment 2

[:Gijs (he/him)]

Attachment: Patch

Might as well.

This also makes it slightly more loose so it'll match if there's a % in front (halfops?). It actually looks like that works already, though I don't quite understand why.

It needs to work with @ in front because that means "op", and because ! counts as a nonword char (\W), it matched bsmedberg's cursing (!@#$%^& or whatever it was).

So yeah. Not much we can do here. #$%^ is an entirely legit channel name, I think. Moznet didn't seem to have a problem with it, anyway

Comment 3

[James Ross]

Comment on attachment 256904 [details] [diff] [review]
Patch

Took me 3 goes reading this patch to spot the additional "," in the regexp. :)

r=silver

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.2; previous revision: 1.1
done