371990 - make no longer functions as expected when run from mozilla/intl/locale/tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ryan Jones-Ward [:sciguyryan]]

|make| no longer functions as expected when run from mozilla/intl/locale/tests.

Comment 1

[Robert Sayre]

discovered in bug 371611

Comment 2

[Simon Montagu :smontagu]

Some code archaeology shows that this can't have worked since the checkin of bug 94831 at 2001-08-16 22:52.

If the files are that out-of-date, I'm not sure that it's worth investing time in making them build, and we'd be better off just wiping the directory and starting from scratch.

Comment 3

[Simon Montagu :smontagu]

sayrer, will you r+ cvs removing intl/locale/tests/nsLocaleTest.cpp and intl/locale/tests/LocaleSelfTest.cpp? I'll leave the makefile alone so as not to conflict with bug 371611.

I filed bug 372022 on creating new tests.

Comment 4

[Ryan Jones-Ward [:sciguyryan]]

Simon, I could remove the un-needed items from the makefile as part of the patch for bug bug 371611 if you can tell me what would no longer be required.

Comment 5

[Simon Montagu :smontagu]

I think that all the lines between 
 include $(DEPTH)/config/autoconf.mk
and
 include $(topsrcdir)/config/rules.mk 
can be removed.

Comment 6

[Ryan Jones-Ward [:sciguyryan]]

(In reply to comment #5)
> I think that all the lines between 
>  include $(DEPTH)/config/autoconf.mk
> and
>  include $(topsrcdir)/config/rules.mk 
> can be removed.
> 

Ok, thanks. I'll remove those lines from the makefile and include that in the patch.

Comment 7

[Robert Sayre]

(In reply to comment #3)
> sayrer, will you r+ cvs removing intl/locale/tests/nsLocaleTest.cpp and
> intl/locale/tests/LocaleSelfTest.cpp? I'll leave the makefile alone so as not
> to conflict with bug 371611.

r=sayrer

Comment 8

[Simon Montagu :smontagu]

Fixed.

Comment 9

[Jeff Walden [:Waldo]]

(In reply to comment #3)
> I filed bug 372022 on creating new tests.

Somehow I doubt this.  What's the real number?  ;-)

Comment 10

[Simon Montagu :smontagu]

That is the real number. It was accidentally marked confidential, but it's open now.