372062 - Auto values for right and bottom in CSS clip rect broken

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[Eli Friedman]

Attachment: Testcase

See testcase.  The whole clip rect is incorrectly getting moved rather than just the top left corner changing.

(How the heck did anyone manage to implement auto clip rects without testing this?)

Should be easy to fix... I'l hold off on making a patch until my other clip fix gets worked out.

Comment 1

[Eli Friedman]

Attachment: Patch

Comment 2

[Eli Friedman]

Comment on attachment 259771 [details] [diff] [review]
Patch

Oops; this version has a typo.

Comment 3

[Eli Friedman]

Attachment: Corrected patch

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We're relying on mClip.x/mClip.y being zero if they're 'auto' (which is true, see
http://lxr.mozilla.org/seamonkey/source/layout/style/nsRuleNode.cpp#2776
). So I think you could comment so in nsStyleStruct.h and then simplify the code by just setting aRect to mClip and then

  if (NS_STYLE_CLIP_RIGHT_AUTO & aDisp->mClipFlags) {
    aRect->width = GetSize().width - aRect->x;
  }

and similarly for bottom.

Comment 5

[Eli Friedman]

Attachment: Patch v3

Okay; changed.

Comment 6

[Eli Friedman]

Checked in with reftest made from the testcase in this bug.