Closed
Bug 372076
Opened 18 years ago
Closed 18 years ago
IConvAdaptor::SetOutputErrorBehavior should handle nsIUnicodeEncoder::kOnError_Signal
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: romaxa, Assigned: sciguyryan)
Details
Attachments
(1 file)
1.03 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
IConvAdaptor::SetOutputErrorBehavior
should also handle nsIUnicodeEncoder::kOnError_Signal: and set
mReplaceOnError = PR_FALSE;
in this case.
Assignee | ||
Comment 1•18 years ago
|
||
Patch v1
* As suggested by Romaxa.
Simon, if this patch is correct do we need a sr here? (I'm not sure on the intl sr policy).
Comment 2•18 years ago
|
||
Comment on attachment 256809 [details] [diff] [review]
patch v1
intl policy is that code changes need sr. For changes that only effect properties files or charset conversion tables, r= from one of the module owners is sufficient.
Attachment #256809 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #2)
> (From update of attachment 256809 [details] [diff] [review])
> intl policy is that code changes need sr. For changes that only effect
> properties files or charset conversion tables, r= from one of the module owners
> is sufficient.
>
I'll remember that thanks. Can you suggest a sr for this case?
Comment 4•18 years ago
|
||
On second thoughts, intl/uconv/native isn't part of the default build, so I don't think you need sr. Go ahead and check in.
Assignee | ||
Updated•18 years ago
|
OS: Linux → All
Hardware: PC → All
Whiteboard: [checkin needed]
Comment 5•18 years ago
|
||
Checked in:
mozilla/intl/uconv/native/nsNativeUConvService.cpp 1.7
Does this need / can this have a unit test?
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Comment 6•18 years ago
|
||
I don't see why not, in theory at least, though as far as I know none of the tinderboxen build with native uconv right now.
Flags: in-testsuite?
Comment 7•18 years ago
|
||
this checkin is causing a libjar unit test to fail, so first we should sort that out.
Comment 8•18 years ago
|
||
(In reply to comment #7)
> this checkin is causing a libjar unit test to fail
nevermind me, it was bug 370103
You need to log in
before you can comment on or make changes to this bug.
Description
•