Closed Bug 372081 Opened 17 years ago Closed 17 years ago

Toolkit profile Service should understand MOZ_PROFILELOCKING option

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 2 obsolete files)

DISABLE SIG Handler patch + indent
3.53 KB, patch
benjamin
: first-review+
mtschrep
: approval1.9+
Details | Diff | Splinter Review
Attached patch Patch 1 (obsolete) — — Splinter Review 
Toolkit profile Service should understand MOZ_PROFILELOCKING option

For some platforms with some debuggers it almost not possible to get Core Dump stack, when Gecko have own sig handlers...
Comment on attachment 256765 [details] [diff] [review]
Patch 1

It still does not work properly in some cases for firefox normal build...

But for xulrunner configuration it more less ok.
Any comments?
Attachment #256765 - Flags: first-review?(benjamin)
Attachment #256765 - Attachment is patch: true
Attachment #256765 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 256765 [details] [diff] [review]
Patch 1

I do not wish to support the --disable-profilelocking option. If you have a specific problem with the unix signal handlers, I would be happy to accept a patch which disables them at runtime using an environment variable (MOZ_DISABLE_PROFILE_SIGNALHANDLERS or something like that).
Attachment #256765 - Flags: first-review?(benjamin) → first-review-
This is ok?
Attachment #256765 - Attachment is obsolete: true
Attachment #260585 - Flags: first-review?(benjamin)
Comment on attachment 260585 [details] [diff] [review]
MOZ_DISABLE_PROFILE_SIGHANDLER env handling

Are you going to reindent the code before checkin?
Yes
Attachment #260585 - Flags: first-review?(benjamin) → first-review+
Assignee: nobody → romaxa

        Attachment #260585 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #260620 -
        Flags: first-review?(benjamin)

    
  

        Attachment #260620 -
        Flags: first-review?(benjamin) → first-review+

    
  
Version: unspecified → Trunk

    
  

        Attachment #260620 -
        Flags: approval1.9?

    
  

        Attachment #260620 -
        Flags: approval1.9? → approval1.9+

    
  
Keywords: checkin-needed

    
    

    
  
Checking in profile/dirserviceprovider/src/nsProfileLock.cpp;
/cvsroot/mozilla/profile/dirserviceprovider/src/nsProfileLock.cpp,v  <--  nsProfileLock.cpp
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11

    
  
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: