372151 - remove non-cairo gfx toolkit configure options

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Since we no longer build without cairo anyway, we might as well remove that option from configure.

Comment 1

[Peter Weilbacher]

Attachment: First try

This removes most of the non-cairo options and also sets cairo-os2 as default for OS/2. I also adapted the output in the --enable-default-toolkit section, so that it lists correct defaults.

Not sure what to do about qt, wince, and photon/qnx which probably don't compile at the moment, or at least not with their default platform toolkit set. Should they be removed? IIRC gtk (as opposed to gtk2) is not an option any more, either, so I removed it.

Anyway, this seems to do what I expected on Linux and OS/2, the two platforms that I have access to.

Comment 2

[Peter Weilbacher]

OK, checked in patch to trunk.

Should we leave this open to decide what to do with qt and other broken (?) platforms or should we file follow-up bugs for each of those?

Comment 3

[Steffen Wilberg]

From bug 375219 comment 13:
> configure auto-generation is disabled until we figure this out. I'll be looking
> at it today.
You might want to check in configure yourself.

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to comment #2)
> OK, checked in patch to trunk.
> 
> Should we leave this open to decide what to do with qt and other broken (?)
> platforms or should we file follow-up bugs for each of those?

If those platforms are broken, they were broken before this, so they can file separate bugs on fixing them.

Thanks for the patch!

Comment 5

[Peter Weilbacher]

(In reply to comment #3)
> You might want to check in configure yourself.

Now I did, thanks for the hint!