372152 - Look into shortening session-saving batch time

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

There seems to be a perception that we are losing pages with session saving. It's not clear how much of thaa is just people doing artificial tests where they intentionally crash/force-quit right after launching and opening a bunch of pages, but even if it is we may run into bad press.

I'll run perf numbers and see how much a shorter batch time would cost.

Comment 1

[Stuart Morgan]

The worst number I saw on my MBP was 0.07 seconds, and it was usually around 0.003, so the main things we get out of batching are not killing people when they open a tab group and giving the pages a little bit of time to settle down to reduce capturing crash loops.

Comment 2

[Stuart Morgan]

Attachment: shorten to 5 seconds

5 seconds will give a much smaller window to lose pages, but still be plenty spaced to avoid hurting perf.

Comment 3

[Josh Aas]

Comment on attachment 257396 [details] [diff] [review]
shorten to 5 seconds

Going from 60 to 5 is pretty steep. Assuming there was some point to having such a high number in the first place, is such a huge change really necessary? What about going to 1/6 instead of 1/12, 10, and seeing how that goes?

I guess what I'm getting at is why was the number so high in the first place, and how does reasoning that fit into your decision to move down to 5 instead of 10, 20, or 30 and checking out the reaction to that?

Comment 4

[Stuart Morgan]

There wasn't a point to 60; I picked it without having done performance testing. Now that I have tested, I know that once every 5 seconds won't be a problem.

Comment 5

[Stuart Morgan]

Attachment: 10 seconds

I'm not particularly attached to 5 though, so lets try 10.

Comment 6

[Josh Aas]

Comment on attachment 258674 [details] [diff] [review]
10 seconds

I'm not particularly opposed to 5 either, just cautious about such a big change and looking for more of an explanation. Lets go with 10 for now and drop it down later if we think it is necessary.

Comment 7

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.