Closed
Bug 372153
Opened 17 years ago
Closed 17 years ago
Denying access to a keychain item causes repeated auth requests
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: thisissamster, Assigned: stuart.morgan+bugzilla)
References
()
Details
(Keywords: fixed1.8.1.4)
Attachments
(1 file)
8.20 KB,
patch
|
jaas
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.2pre) Gecko/20070223 Camino/1.1b Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.2pre) Gecko/20070223 Camino/1.1b When I first accessed gamefaqs.com, I guess the system accessed my firefox saved passwords and tried to log me into an account that i don't have anymore. It asked me if I wanted to login. If i pressed "deny", it would pop right back up as soon as I let go. Allow once only put the pop-up aside for a couple of seconds, and I never tried allow forever. After i saved my new account the problem went away. Reproducible: Didn't try Steps to Reproduce: 1. Reinstall Camino so that no cookies or any sort of saved item exists. 2. Have a nonexistent login account saved in firefox. 3. go to www.gamefaqs.com in camino Actual Results: I didn't want to go through the hassle of reinstalling camino so I didn't try
Assignee | ||
Comment 1•17 years ago
|
||
We don't read anything from Firefox. Could you describe what this looked like? Was it a sheet, or a dialog? Do you remember the specific text?
Comment 2•17 years ago
|
||
The "hassle of reinstalling Camino" is really no more complicated than using http://pimpmycamino.com/parts/troubleshoot-camino Please try to reproduce this issue, and get screen shots if you can.
Can you please respond to comment 1 and 2?
Whiteboard: [CLOSEME - 3/11]
hi sorry it took a while. It was a dialog that popped up. I'll download the new nightly build later on tonight and see if I can recreate it.
alright. i tried it again and got the same dialog, except it isn't as serious as I thought it was when i used camino for the first time and got the error. In fact it isn't even an error. It's just camino accessing my keychain and trying to use a password I have saved there from firefox (or however it got there) for an account I don't have anymore. It would be nice, however, if when I pressed "deny" (for using the exising account in the keychain) the dialog stopped popping up. it really is annoying to have to press deny over and over and over again, to no avail. hope i was of some help and not just a nuisance!
and if you want to recreate the dialog, you don't need to reinstall camino. you just need to reset it. maybe clearing the cache would be enough.
Assignee | ||
Comment 7•17 years ago
|
||
Just to be clear: when you visit a single page, you get a keychain request, and no matter how many times you say "deny" it continues to ask without you going to any other pages?
Assignee | ||
Comment 8•17 years ago
|
||
Nevermind, I understand now. We don't handle Deny at all gracefully.
Assignee: nobody → stuart.morgan
Severity: minor → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: when I first accessed gamefaqs.com, a log-in popup keeps coming up → Denying access to a keychain item causes repeated auth requests
Whiteboard: [CLOSEME - 3/11]
Assignee | ||
Comment 9•17 years ago
|
||
This separates loading the password (which is what triggers an auth request) from the rest of the data, so that we don't make unnecessary auth requests, and adds checks of candidate items in the higher level before returning one. I'd been meaning to do this anyway to improve the experience of accessing a site with multiple stored Safari entries (why make them allow access to all of them when we can only use one), but this is a much more important case that I hadn't considered.
Attachment #259657 -
Flags: review?(joshmoz)
Attachment #259657 -
Flags: review?(joshmoz) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #259657 -
Flags: superreview?(mikepinkerton)
Reporter | ||
Comment 10•17 years ago
|
||
i wish i could help you out but i don't have enough technical know-how to actually be of any use! thanks if you were able to fix that problem though
Comment 12•17 years ago
|
||
Comment on attachment 259657 [details] [diff] [review] fix sr=pink
Attachment #259657 -
Flags: superreview?(mikepinkerton) → superreview+
Assignee | ||
Comment 13•17 years ago
|
||
Checked in on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
Target Milestone: --- → Camino1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•