Closed Bug 372226 Opened 17 years ago Closed 8 years ago

safe browsing code does something unnecessarily slow for large data: URIs

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
major
Points:
5

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: dbaron, Unassigned)

Details

(Keywords: perf, regression) 

The safe browsing code that's written in javascript seems to do an unnecessarily large amount of work for large data URIs.  I'm not sure how the safe browsing code should really be treating data URIs, but it can get really slow, especially when repeated 50 times (see bug 372225).

Steps to reproduce:
 1. open 50 firefox windows
 2. in one of them, load attachment 253740 [details]
 3. right click on one of the "IMAGE 1" or "IMAGE 2" links and open it in a new tab

Actual results:  CPU is pegged for 20 seconds or so, although I can interact with the browser (although it's sluggish)

Expected results:  CPU not pegged for 20 seconds.  Safe browsing code doesn't repeat its work once per top level window.


In combination with bug 372225, this makes looking at reftest results almost unusable.

But even if bug 372225 is fixed, I think this should be addressed -- the URIs in question are only a few thousand characters long, so the performance really shouldn't be that horrible when repeating the work 50 times -- this suggests that safe browsing would be taking up a significant portion of pageload time even with bug 372225 fixed.
Flags: blocking-firefox3?
Boris just pointed out bug 370860, which was fixed yesterday -- my build is older than that, I think.
dbaron, when you get a chance can you see if the fixes to bug 370860 and bug 372225 resolve this?
I doubt 370860 helped, just filed bug 379390 on an http: url that similarly hangs us even after the fix for bug 370860.
Not a blocker, but we'd want a fix for this if possible.
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [wanted-firefox3]
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
Whiteboard: [defect] p=0
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: [defect] p=0 → p=0
Whiteboard: p=0 → p=5
Product: Firefox → Toolkit
Points: --- → 5
Flags: qe-verify?
Whiteboard: p=5
I can't reproduce following the instructions in comment 0 so I'll assume it got fixed someone in the past 9 years.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.