372250 - Additional Smileys

Status: RESOLVED DUPLICATE of bug 393367

(Other Applications :: ChatZilla, enhancement)

Description

[Joerg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: latest

Hi folks,

there are some already existing but unused smileys in the irc/xul/skin/images/ directory, but apparently it has been forgotten to address them in the code.

Adding the following lines at irc/xul/content/mungers.js after line 407 should improve this, maybe you can include them in an upcoming chatzilla release:

else if (emoticon.search(/[:;][-^]!/) != -1)
    type = "face-exclaim";
else if (emoticon.search(/[:;][-^][xX\*]/) != -1)
    type = "face-razz";
else if (emoticon.search(/[-=][-=]?>/) != -1)
    type = "face-arrow";

For Mr. Green and the idea smiley it's not as obvious as above, but maybe we could use:

else if (emoticon.search(/[:;][-^][Gg]/) != -1)
    type = "face-mrgreen";
else if (emoticon.search(/[:;][-^][Ii]/) != -1)
    type = "face-idea";

cya,
Joerg


Reproducible: Always

Comment 1

[:Gijs (out for now; he/him)]

OK, so you were here first, but the other bug has a patch. Duping this to that. If people don't like removing the smilies we might look at your idea - thanks!