372262 - CZ does not send text over DCC-Chat

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Merlyel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Chatzilla 0.9.77-rdmsoft [XULRunner 1.8.0.4/2006060814] BuildID:2007021411, 2007010907

Latest nightlies does not send normally text over DCC-Chat, but receives normally.
Upon sending some text, you receive 
"[ERROR]	this_dispatch: Command “say” must be run in the context of an attached server. @ <chrome://chatzilla/content/commands.js> 342" response, while DCC-FileSend works fine.

Reproducible: Always

Steps to Reproduce:
1. Open DCC-connection
2. Try saying something
Actual Results:  
Error message is received.

Comment 1

[:Gijs (he/him)]

yeah, this is my regression thing. dispatching say was not a good idea, in some sense. We should really fix /say to work on dcc chat tabs though. James, got ideas about how we should do that? I'm personally voting for a new commandmanager flag thing.

Comment 2

[:Gijs (he/him)]

Attachment: Patch

Actually, I've re-thought my position. Let's do the same thing we already do for /me - just don't require anything and check whether the object knows about "say" or "act", respectively. Yay for one-line-patches!

Comment 3

[James Ross]

Comment on attachment 257842 [details] [diff] [review]
Patch

Oh, go on then. :P

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/commands.js;
/cvsroot/mozilla/extensions/irc/xul/content/commands.js,v  <--  commands.js
new revision: 1.121; previous revision: 1.120
done