372283 - preview layout issues when feed includes html in CDATA

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Hassan El Forkani]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2

the feed preview layout is altered when feed contains html in CDATA blocks (image tags) the issue is with line breaks and separation between items

tested with valid RSS2

Reproducible: Always

Steps to Reproduce:
1.preview RSS2 feed with images in CDATA blocks
2.
3.
Actual Results:  
layout messed, items tabbed to the right

Expected Results:  
not incremental tab between items

Comment 1

[Robert Sayre]

Attachment: clear block elements

maybe there is a -moz css property I can put on .feedEntry divs to get this effect, but this works too.

Comment 2

[Robert Sayre]

Attachment: set clear on the element, not in subscribe.css

Comment 3

[Asaf Romano (gone)]

Comment on attachment 257253 [details] [diff] [review]
set clear on the element, not in subscribe.css

r=mano.

Comment 4

[Robert Sayre]

Comment on attachment 257253 [details] [diff] [review]
set clear on the element, not in subscribe.css

low risk presentation fix

Comment 5

[Robert Sayre]

Checking in FeedWriter.js;
/cvsroot/mozilla/browser/components/feeds/src/FeedWriter.js,v  <--  FeedWriter.js
new revision: 1.37; previous revision: 1.36
done

Comment 6

[Robert Sayre]

Comment on attachment 257253 [details] [diff] [review]
set clear on the element, not in subscribe.css

no one answered the 2.0.0.3 approval request, so let's assume it is going to make 2.0.0.4 instead.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 257253 [details] [diff] [review]
set clear on the element, not in subscribe.css

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 8

[juan becerra [:juanb]]

Robert, Please land your 1.8.1.4 approved patches as soon as possible. Code freeze was pushed out to this Friday, April 27. 

Comment 9

[Robert Sayre]

Checking in FeedWriter.js;
/cvsroot/mozilla/browser/components/feeds/src/FeedWriter.js,v  <--  FeedWriter.js
new revision: 1.2.2.31; previous revision: 1.2.2.30
done

Comment 10

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 using  Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4pre) Gecko/2007042805 BonEcho/2.0.0.4pre and tested with the URL provided in this Bug, no problem on the layout/preview layout issues.