372366 - After database schema upgrade 6 -> 7 all events are floating, timezone is lost

Status: VERIFIED FIXED

(Calendar :: Provider: Local Storage, defect, P1)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070301 Calendar/0.5pre

After switching from Sunbird/0.5pre (2007022804) to Sunbird/0.5pre (2007030104) all events are shifted by -x hours, with x being the UTC offset of your timezone. During that switch the database schema upgrade 6 -> 7 took place.

Exporting the storage calendar to ics shows the problem: 
All tz information is lost, events are converted to UTC and marked floating.

Event created and exported in Sunbird/0.5pre (2007022804):

BEGIN:VEVENT
CREATED:20070302T103132Z
LAST-MODIFIED:20070302T103132Z
DTSTAMP:20070302T103132Z
UID:b4268a32-0601-493c-9fde-0edfddb2e816
SUMMARY:2 Mar 1000-1200
DTSTART;TZID=/mozilla.org/20070129_1/Europe/Berlin:20070302T100000
DTEND;TZID=/mozilla.org/20070129_1/Europe/Berlin:20070302T120000
END:VEVENT
BEGIN:VEVENT

BEGIN:VEVENT
CREATED:20070302T103132Z
LAST-MODIFIED:20070302T103132Z
DTSTAMP:20070302T103132Z
UID:d65546eb-cbb6-4a45-9bff-dba5660dbf64
SUMMARY:28 Feb all day
DTSTART;VALUE=DATE;TZID=/mozilla.org/20070129_1/Europe/Berlin:20070228
DTEND;VALUE=DATE;TZID=/mozilla.org/20070129_1/Europe/Berlin:20070301
END:VEVENT


Event exported in Sunbird/0.5pre (2007030104):

BEGIN:VEVENT
CREATED:20070302T103253Z
LAST-MODIFIED:20070302T103253Z
DTSTAMP:20070302T103253Z
UID:b4268a32-0601-493c-9fde-0edfddb2e816
SUMMARY:2 Mar 1000-1200
DTSTART:20070302T090000
DTEND:20070302T110000
END:VEVENT

BEGIN:VEVENT
CREATED:20070302T103253Z
LAST-MODIFIED:20070302T103253Z
DTSTAMP:20070302T103253Z
UID:d65546eb-cbb6-4a45-9bff-dba5660dbf64
SUMMARY:28 Feb all day
DTSTART;VALUE=DATE:20070227
DTEND;VALUE=DATE:20070228
END:VEVENT

Comment 1

[Matthew (lilmatt) Willis]

Taking this

Comment 2

[Matthew (lilmatt) Willis]

Attachment: Fixes comparison

The code made the erroneous assumption that calICSService::GetLatestTzId would always return the latestTzId, even if the one it was passed in WAS the latest.  Instead in that case it returns nothing.

This fixes the assumption to reflect reality.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 257025 [details] [diff] [review]
Fixes comparison

r=mvl

Comment 4

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 5

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3pre) Gecko/20070304 Calendar/0.5pre

Comment 6

[Myk Melez [:myk] [@mykmelez]]

I ran into this problem, and I too can verify that it's now fixed in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3pre) Gecko/20070305 Calendar/0.5pre