Closed Bug 372391 Opened 13 years ago Closed 9 years ago

reftest manifests should use a different comment character

Categories

(Testing :: Reftest, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sayrer, Unassigned)

References

Details

I have a test that needs a fragment identifier in the URI, but reftest uses '#' to signal a comment.
Blocks: 372377
Does ";" seem reasonable?
"|" is an alternative that isn't allowed to appear in a URI. ";" is a delimiter in a query string. However, it seems unlikely that we'll ever need to test ";" behavior, and I realize "|" isn't very comment-like. Your call.
"|" does appear in some web site URLs and in most file: URLs on Windows.  See duplicates of bug 221445 for some examples.  Maybe reftests won't use those URLs, though.

How about continuing to use "#" but only treating it as a comment if it is at the beginning of a line or immediately preceded by whitespace?
Component: Testing → Reftest
Product: Core → Testing
Version: Trunk → unspecified
QA Contact: testing → reftest
(In reply to comment #3)
> How about continuing to use "#" but only treating it as a comment if it is at
> the beginning of a line or immediately preceded by whitespace?

We now do that, so sayre's use case would seem to be fixed. Okay to close this Robert?
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.